Paths

Table of Contentst

Differential D10601

[backup] Log cleanup
ClosedPublic
Actions

Authored by michal on Jan 11 2024, 7:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 27, 7:21 PM

	Unknown Object (File)
	Fri, Dec 27, 7:21 PM

	Unknown Object (File)
	Fri, Dec 27, 7:21 PM

	Unknown Object (File)
	Fri, Dec 27, 7:21 PM

	Unknown Object (File)
	Fri, Dec 20, 8:38 AM

	Unknown Object (File)
	Nov 21 2024, 3:58 AM

	Unknown Object (File)
	Nov 21 2024, 3:58 AM

	Unknown Object (File)
	Nov 6 2024, 3:46 AM

View All 47 Files

Subscribers

Details

Reviewers

bartek
kamil

Commits

rCOMM6e6d6b926051: [backup] Log cleanup

Summary

For some reason I completely forgot about this. This diff adds logic for removing logs after the corresponding backup is deleted.

Test Plan

Run the updated integration test. All 30 logs were removed.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Jan 11 2024, 7:26 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 11 2024, 7:26 AM

michal added inline comments.Jan 11 2024, 7:29 AM

services/backup/src/database/mod.rs
294–320 ↗	(On Diff #35530)	This could be done more efficiently but it would required changes to `batch_write`. It would need to start accepting a request stream instead of a complete vector. This way we could run both fetch and deletion in parallel. If the performance turns out to be a problem we could implement that but I don't think this should be prioritized right now.

Harbormaster completed remote builds in B25694: Diff 35530.Jan 11 2024, 7:50 AM

michal requested review of this revision.Jan 11 2024, 7:50 AM

bartek accepted this revision.Jan 11 2024, 9:24 AM

This revision is now accepted and ready to land.Jan 11 2024, 9:24 AM

Closed by commit rCOMM6e6d6b926051: [backup] Log cleanup (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJan 16 2024, 7:56 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM6e6d6b926051: [backup] Log cleanup.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

database/

21 lines

49 lines

commtest/

tests/

backup_integration_test.rs

33 lines

Diff 35677

services/backup/src/database/log_item.rs

Loading...

services/backup/src/database/mod.rs

Loading...

services/commtest/tests/backup_integration_test.rs

Loading...