This creates an overlay with the last nixpkgs revision 9957cd48326fe8dbd52fdc50dd2502307f188b0d to have grpc-web version 1.4.2
and replaces the dev-shell installation which uses the latest nixpkgs-unstable grpc-web package.
Details
Details
Successfully ran nix develop and it installed 1.4.2 properly
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- nix-grpc-web
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Thanks for putting this out so quickly! Unfortunately, it seems like there's still a problem:
varun@varuns-MacBook-Pro web % yarn codegen-identity-grpc yarn run v1.22.19 $ ./scripts/codegen-identity-grpc.sh /nix/store/7qj55bw020lvz0246lbz2ap7ji6sd275-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web: /nix/store/7qj55bw020lvz0246lbz2ap7ji6sd275-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web: cannot execute binary file --grpc-web_out: protoc-gen-grpc-web: Plugin failed with status code 126. error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
I think the protoc-gen-grpc-web binary you added is compiled for a different architecture
Comment Actions
After yarn arc-patching this diff:
varun@varuns-MacBook-Pro web % file /nix/store/7qj55bw020lvz0246lbz2ap7ji6sd275-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web /nix/store/7qj55bw020lvz0246lbz2ap7ji6sd275-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /nix/store/ld03l52xq2ssn4x0g5asypsxqls40497-glibc-2.37-8/lib/ld-linux-x86-64.so.2, for GNU/Linux 3.10.0, not stripped
After checking out an old commit from before protoc-gen-grpc-web was upgraded to 1.5.0:
varun@varuns-MacBook-Pro web % file /nix/store/048hbnyjjg6r86k92nsbmvcq736bvn5k-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web /nix/store/048hbnyjjg6r86k92nsbmvcq736bvn5k-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
flake.nix | ||
---|---|---|
18 | I think this should be arm64 |
flake.nix | ||
---|---|---|
18 | That was an oversight. I believe we're on aarch64-darwin |
Comment Actions
Switch to aarch64-darwin. Just ran the web protobuf gen script and everything seems to be working. Let me know if there's any other issues