Page MenuHomePhabricator
Differential D10749

[web] implementing getting outbound user keys in `IdentityServiceClient`
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 2:18 AM.
Tags
None
Referenced Files
F2213461: D10749.id36231.diff
Mon, Jul 8, 1:07 PM
F2213433: D10749.id36209.diff
Mon, Jul 8, 12:57 PM
F2213326: D10749.id35904.diff
Mon, Jul 8, 12:45 PM
Unknown Object (File)
Fri, Jul 5, 9:42 AM
Unknown Object (File)
Mon, Jul 1, 11:38 AM
Unknown Object (File)
Mon, Jul 1, 11:38 AM
Unknown Object (File)
Mon, Jul 1, 11:38 AM
Unknown Object (File)
Mon, Jul 1, 11:37 AM
View All 39 Files
Subscribers
ashoat

Details

Reviewers
tomek
varun
Commits
rCOMM901cb3bc1c1e: [web] implementing getting outbound user keys in `IdentityServiceClient`
Summary

Call RPC to get the keys of all devices of a given user.

This approach is different, we want to:

  1. Return all user devices
  2. Return valid user keys even though one device has for example missing one-time keys

    Depends on D10748
Test Plan

Call method and log result

Diff Detail

Repository
rCOMM Comm
Branch
publish-web-outbound
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jan 22 2024, 2:18 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJan 22 2024, 2:18 AM
kamil edited the summary of this revision. (Show Details)Jan 22 2024, 2:21 AM
kamil added a child revision: D10750: [native] implementing getting outbound user keys in `IdentityServiceClient`.Jan 22 2024, 2:21 AM
Harbormaster failed remote builds in B25972: Diff 35904!Jan 22 2024, 2:48 AM
kamil published this revision for review.Jan 22 2024, 4:37 AM
tomek accepted this revision.Jan 22 2024, 8:11 AM
tomek added inline comments.
web/grpc/identity-service-client-wrapper.js
141

Shouldn't we check if it is an array?

187

Shouldn't we check the type of deviceID?

This revision is now accepted and ready to land.Jan 22 2024, 8:11 AM
kamil updated this revision to Diff 36209.Jan 27 2024, 6:41 AM

add checks

Harbormaster failed remote builds in B26216: Diff 36209!Jan 27 2024, 6:48 AM
This revision was landed with ongoing or failed builds.Jan 29 2024, 2:00 AM
Closed by commit rCOMM901cb3bc1c1e: [web] implementing getting outbound user keys in `IdentityServiceClient` (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM901cb3bc1c1e: [web] implementing getting outbound user keys in `IdentityServiceClient`.

Revision Contents
Changeset List

PathSize
lib/
types/
8 lines
web/
grpc/
70 lines

Diff 35904

View Options

lib/types/identity-service-types.js

Loading...
View Options

web/grpc/identity-service-client-wrapper.js

Loading...