Page MenuHomePhabricator

[web] implementing getting outbound user keys in `IdentityServiceClient`
ClosedPublic

Authored by kamil on Jan 22 2024, 2:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 1:24 AM
Unknown Object (File)
Oct 18 2024, 12:53 AM
Unknown Object (File)
Oct 18 2024, 12:53 AM
Unknown Object (File)
Oct 18 2024, 12:53 AM
Unknown Object (File)
Oct 18 2024, 12:53 AM
Unknown Object (File)
Oct 18 2024, 12:53 AM
Unknown Object (File)
Sep 6 2024, 8:40 PM
Unknown Object (File)
Sep 6 2024, 8:40 PM
Subscribers

Details

Summary

Call RPC to get the keys of all devices of a given user.

This approach is different, we want to:

  1. Return all user devices
  2. Return valid user keys even though one device has for example missing one-time keys

    Depends on D10748
Test Plan

Call method and log result

Diff Detail

Repository
rCOMM Comm
Branch
publish-outbound-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jan 22 2024, 4:37 AM
tomek added inline comments.
web/grpc/identity-service-client-wrapper.js
141 ↗(On Diff #35904)

Shouldn't we check if it is an array?

187 ↗(On Diff #35904)

Shouldn't we check the type of deviceID?

This revision is now accepted and ready to land.Jan 22 2024, 8:11 AM
This revision was landed with ongoing or failed builds.Jan 29 2024, 2:00 AM
This revision was automatically updated to reflect the committed changes.