Paths

Table of Contentst

Differential D10782

[tunnelbroker] Add support for unauthenticated websocket sessions
ClosedPublic
Actions

Authored by bartek on Jan 22 2024, 5:32 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 11:51 AM

	Unknown Object (File)
	Fri, Nov 1, 5:04 AM

	Unknown Object (File)
	Fri, Nov 1, 5:04 AM

	Unknown Object (File)
	Oct 2 2024, 12:32 PM

	Unknown Object (File)
	Oct 2 2024, 12:32 PM

	Unknown Object (File)
	Oct 2 2024, 12:32 PM

	Unknown Object (File)
	Oct 2 2024, 12:32 PM

	Unknown Object (File)
	Sep 17 2024, 10:52 PM

View All 68 Files

Subscribers

Details

Reviewers

kamil
michal

Commits

rCOMM836a8c6c9b0f: [tunnelbroker] Add support for unauthenticated websocket sessions

Summary

Resolves ENG-4381.
Added tunnelbroker support for starting anonymous sessions, which omit the VerifyUserAccessToken RPC cal RPC call.
As for now, the anonymous sessions can only listen for messages, and cannot send any.

Depends on D10779.

Test Plan

Modified client code to send AnonymousInitializationMessage instead of ConnectionInitializationMessage
Verified that websocket session is started
Verified that the device can receive messages
Verified that sending a message from anonymous session results in receiving MessageSentStatus::Unauthenticated error.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 22 2024, 5:32 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 5:32 AM

Harbormaster completed remote builds in B26024: Diff 35958.Jan 22 2024, 5:51 AM

bartek published this revision for review.Jan 26 2024, 1:50 AM

bartek added a child revision: D10832: [lib] Tunnelbroker support for unauthorized sessions.Jan 26 2024, 6:08 AM

I think we can remove notify_token, but we can discuss it in D10779. LGTM

services/tunnelbroker/src/websockets/session.rs
37 ↗	(On Diff #35958)	Given the Message type defined I think `is_anonymous` seems more natural but up to you - both are okay

This revision is now accepted and ready to land.Jan 26 2024, 9:01 AM

bartek added inline comments.Jan 29 2024, 1:47 AM

services/tunnelbroker/src/websockets/session.rs
37 ↗	(On Diff #35958)	In this context, `is_authenticated` seems to make more sense to me, We can rename it any time later if we change our minds

Remove notify_token from anonymous message

Harbormaster completed remote builds in B26235: Diff 36228.Jan 29 2024, 2:07 AM

Closed by commit rCOMM836a8c6c9b0f: [tunnelbroker] Add support for unauthenticated websocket sessions (authored by bartek). · Explain WhyJan 29 2024, 2:16 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM836a8c6c9b0f: [tunnelbroker] Add support for unauthenticated websocket sessions.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

websockets/

25 lines

Diff 36238

services/tunnelbroker/src/websockets/session.rs

Loading...