Page MenuHomePhabricator
Differential D10982

[native] fix oversized username container in message header
ClosedPublic
Actions

Authored by ginsu on Feb 7 2024, 12:39 AM.
Tags
None
Referenced Files
F2188796: D10982.id36809.diff
Thu, Jul 4, 9:34 AM
F2188794: D10982.id36811.diff
Thu, Jul 4, 9:34 AM
F2188453: D10982.id36766.diff
Thu, Jul 4, 9:18 AM
F2188397: D10982.id36767.diff
Thu, Jul 4, 9:10 AM
Unknown Object (File)
Tue, Jul 2, 6:45 AM
Unknown Object (File)
Sun, Jun 23, 11:24 PM
Unknown Object (File)
Sun, Jun 23, 11:08 PM
Unknown Object (File)
Thu, Jun 20, 1:16 AM
View All 39 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM42116c6abac3: [native] fix oversized username container in message header
Summary

This diff fixes a bug where the username container in the message header was oversized so pressing to the right of it would open up the profile bottom sheet

Linear task: https://linear.app/comm/issue/ENG-6458/pressing-to-the-right-of-username-on-native-opens-profile

Test Plan

Please see demo video + screenshot below

this is a screenshot of the container now

Screenshot 2024-02-07 at 3.49.05 AM.png (1×944 px, 658 KB)

Diff Detail

Repository
rCOMM Comm
Branch
eng-6458
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Feb 7 2024, 12:39 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 7 2024, 12:39 AM
ginsu updated this revision to Diff 36767.Feb 7 2024, 12:48 AM

update

ginsu edited the summary of this revision. (Show Details)Feb 7 2024, 12:50 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F1124562: Screenshot 2024-02-07 at 3.49.05 AM.png. (Show Details)
Harbormaster completed remote builds in B26609: Diff 36766.Feb 7 2024, 12:56 AM
Harbormaster completed remote builds in B26610: Diff 36767.Feb 7 2024, 1:40 AM
ginsu requested review of this revision.Feb 7 2024, 1:40 AM
atul accepted this revision.Feb 7 2024, 12:57 PM
This revision is now accepted and ready to land.Feb 7 2024, 12:57 PM
ginsu updated this revision to Diff 36809.Feb 7 2024, 1:55 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 7 2024, 2:08 PM
Closed by commit rCOMM42116c6abac3: [native] fix oversized username container in message header (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM42116c6abac3: [native] fix oversized username container in message header.
Harbormaster completed remote builds in B26637: Diff 36809.Feb 7 2024, 2:12 PM

Revision Contents
Changeset List

PathSize
native/
chat/
23 lines

Diff 36766

View Options

native/chat/message-header.react.js

Loading...