Page MenuHomePhabricator

[dev env] add toolchain file
ClosedPublic

Authored by varun on Feb 8 2024, 12:44 PM.
Tags
None
Referenced Files
F3501178: D11004.diff
Fri, Dec 20, 3:30 AM
Unknown Object (File)
Nov 16 2024, 5:55 PM
Unknown Object (File)
Nov 16 2024, 5:55 PM
Unknown Object (File)
Nov 16 2024, 5:55 PM
Unknown Object (File)
Nov 16 2024, 5:55 PM
Unknown Object (File)
Oct 14 2024, 9:57 PM
Unknown Object (File)
Oct 14 2024, 9:57 PM
Unknown Object (File)
Oct 14 2024, 9:57 PM
Subscribers

Details

Summary

this file ensures all devs are using the same rustup toolchain. docs on toolchain file here: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

Test Plan

confirmed that the specified rustup toolchain (1.75) overrode my previously installed toolchain inside the repo.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rust-toolchain.toml
1–3 ↗(On Diff #36887)

not handling adding other targets here because we add them in native/android/app/build.gradle and scripts/ensure_rustup_setup.sh

2 ↗(On Diff #36887)

The channel setting specifies which toolchain to use. 1.75 is the same version we use in our services Dockerfiles

3 ↗(On Diff #36887)

default is the minimal install plus rust-docs, rustfmt, and clippy

varun requested review of this revision.Feb 8 2024, 1:01 PM

This looks great, but I'd like one of the people that actually knows Rust to take a look too

This revision is now accepted and ready to land.Feb 9 2024, 2:26 AM
This revision was automatically updated to reflect the committed changes.