Page MenuHomePhabricator
Differential D10572

[web] introduce light mode to thread notifications modal
ClosedPublic
Actions

Authored by ginsu on Jan 8 2024, 1:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 7:09 PM
Unknown Object (File)
Thu, Dec 5, 9:44 AM
Unknown Object (File)
Thu, Dec 5, 9:42 AM
Unknown Object (File)
Thu, Dec 5, 9:42 AM
Unknown Object (File)
Thu, Dec 5, 9:40 AM
Unknown Object (File)
Thu, Dec 5, 9:22 AM
Unknown Object (File)
Nov 8 2024, 11:20 AM
Unknown Object (File)
Nov 1 2024, 11:21 PM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMee2fa75c836e: [web] introduce light mode to thread notifications modal
Summary

This diff introduces the new color design system/light mode to the thread notifications modal

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

Linear task: https://linear.app/comm/issue/ENG-5039/thread-notifications-modal

Depends on D10571

Test Plan

Please see screenshots below

dark:

Screenshot 2024-01-08 at 4.27.01 AM.png (2×3 px, 953 KB)

light:

Screenshot 2024-01-08 at 4.27.28 AM.png (2×3 px, 976 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 8 2024, 1:26 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 8 2024, 1:26 AM
ginsu published this revision for review.Jan 8 2024, 1:33 AM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D10571: [web] introduce light mode to sidebar promote modal.
ginsu attached a referenced file: F1043833: Screenshot 2024-01-08 at 4.27.28 AM.png. (Show Details)
ginsu attached a referenced file: F1043832: Screenshot 2024-01-08 at 4.27.01 AM.png. (Show Details)

will make sure ci passes before landing

Harbormaster failed remote builds in B25581: Diff 35348!Jan 8 2024, 1:52 AM
atul accepted this revision.Jan 8 2024, 12:26 PM

9d0380.png (138×126 px, 5 KB)

Hm, radio button doesn't have much contrast when selected. Guessing that component will get updated later as part of this work?

This revision is now accepted and ready to land.Jan 8 2024, 12:26 PM
ginsu added a comment.Feb 20 2024, 10:26 PM

Hm, radio button doesn't have much contrast when selected. Guessing that component will get updated later as part of this work?

created this linear task to track this comment
https://linear.app/comm/issue/ENG-6886/confirm-the-light-mode-radio-button-colors

ginsu updated this revision to Diff 37383.Feb 20 2024, 10:26 PM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing

Harbormaster completed remote builds in B27018: Diff 37383.Feb 20 2024, 10:41 PM
Closed by commit rCOMMee2fa75c836e: [web] introduce light mode to thread notifications modal (authored by ginsu). · Explain WhyFeb 20 2024, 11:11 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMee2fa75c836e: [web] introduce light mode to thread notifications modal.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
notifications/
3 lines

Diff 37383

View Options

web/modals/threads/notifications/notifications-modal.css

Loading...