[native] Don't dispatch an undefined token
ClosedPublic
Actions

Authored by tomek on Feb 21 2024, 4:39 AM.

Details

Reviewers

inka
atul
varun

Commits

rCOMM50d8fe4a69f2: [native] Don't dispatch an undefined token

Summary

CommCoreModule can return an undefined token. We're replacing it with null, because otherwise redux-persis won't persist it.

https://linear.app/comm/issue/ENG-6849/expected-keys-not-rehydrated-[commservicesaccesstoken]

Test Plan

Without this diff: restart the app - the warning should be shown. Apply this diff and restart the app - the warning shouldn't appear.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Feb 21 2024, 4:39 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 21 2024, 4:39 AM

Harbormaster completed remote builds in B27023: Diff 37390.Feb 21 2024, 4:55 AM

tomek requested review of this revision.Feb 21 2024, 4:55 AM

inka accepted this revision.Feb 21 2024, 5:36 AM

This revision is now accepted and ready to land.Feb 21 2024, 5:36 AM

varun accepted this revision.Feb 21 2024, 6:33 AM

Closed by commit rCOMM50d8fe4a69f2: [native] Don't dispatch an undefined token (authored by tomek). · Explain WhyFeb 21 2024, 8:08 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM50d8fe4a69f2: [native] Don't dispatch an undefined token.

Revision Contents
Changeset List

Path

Size

lib/

types/

redux-types.js

2 lines

native/

components/

access-token-handler.react.js

2 lines

Diff 37390

View Options

lib/types/redux-types.js