Page MenuHomePhabricator
Differential D11136

[native] Fix for encrypted media
ClosedPublic
Actions

Authored by atul on Feb 21 2024, 11:35 AM.
Tags
None
Referenced Files
F2834977: D11136.id37411.diff
Sat, Sep 28, 12:26 PM
F2834130: D11136.diff
Sat, Sep 28, 10:16 AM
Unknown Object (File)
Fri, Sep 13, 6:44 PM
Unknown Object (File)
Fri, Sep 13, 12:40 PM
Unknown Object (File)
Fri, Sep 13, 11:13 AM
Unknown Object (File)
Mon, Sep 9, 10:49 PM
Unknown Object (File)
Mon, Sep 9, 10:49 PM
Unknown Object (File)
Mon, Sep 9, 10:49 PM
View All 53 Files
Subscribers
bartek

Details

Reviewers
ashoat
ginsu
tomek
bartek
Commits
rCOMMa3d27f5b40ed: [native] Fix for encrypted media
Summary

Context can be found here: https://linear.app/comm/issue/ENG-6850/build-316-cant-load-encrypted-images

Just removing getAuthMetadata call for now and passing undefined to fetchAndDecryptMedia.

NOTE: I know that I could further "simplify" useFetchAndDecryptMedia by removing the useContext, removing the outer function, etc. but I want to keep the API the same so @bartek or whoever in the future can drop getAuthMetadata back in.
Test Plan

Able to view encrypted images again:

001c3c.png (1×744 px, 385 KB)

Set breakpoints through fetchAndDecryptMedia and ensured that things worked as expected without auth metadata.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 21 2024, 11:35 AM
atul published this revision for review.Feb 21 2024, 11:35 AM
atul edited the test plan for this revision. (Show Details)
ashoat accepted this revision.Feb 21 2024, 11:39 AM
This revision is now accepted and ready to land.Feb 21 2024, 11:39 AM
Harbormaster failed remote builds in B27042: Diff 37410!Feb 21 2024, 11:47 AM
ashoat added a comment.Feb 21 2024, 11:51 AM

We should fix the Flow issues before landing

atul updated this revision to Diff 37411.Feb 21 2024, 12:01 PM

stage all

Harbormaster completed remote builds in B27043: Diff 37411.Feb 21 2024, 12:20 PM
Closed by commit rCOMMa3d27f5b40ed: [native] Fix for encrypted media (authored by atul). · Explain WhyFeb 21 2024, 12:52 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMa3d27f5b40ed: [native] Fix for encrypted media.

Revision Contents
Changeset List

PathSize
native/
media/
22 lines

Diff 37413

View Options

native/media/encryption-utils.js

Loading...