issue: ENG-6634
We need the constant that is currently called ashoatKeyserverID to be configurable. We have two different ways of configuring things on web vs native. On native we can just import .json files. On we we cannot do that (this is complicated why, see ENG-1181 for more info), so we use a workaround. I followed D7371 for that
Details
Created authoritativeKeyserverID.json
{ "authoritativeKeyserverID": "256" }
in keyserver/facts and native/facts. Added a console log on both web and native and checked that value from the config is logged (it was set to something else than ashoatKeyserverID)
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
native/authoritative-keyserver-id.js | ||
---|---|---|
3–12 ↗ | (On Diff #36928) |
native/authoritative-keyserver-id.js | ||
---|---|---|
8 ↗ | (On Diff #36928) | We should update the docs to include some info about creating this file. Also, I think that it would be better to have authoritativeKeyserver.json file which contains an ID. If we ever decide to store more info about this keyserver, it would be more convenient. |
12 ↗ | (On Diff #36928) | Do we really need to have fromJSON suffix? It seems to be an implementation detail. Is there a risk of confusion if we name it authoritativeKeyserverID? |
web/webpack.config.cjs | ||
16 ↗ | (On Diff #36849) | Was the error there before your changes? I guess we should test if the new code works on prod. |
native/authoritative-keyserver-id.js | ||
---|---|---|
8 ↗ | (On Diff #36928) |
Is this really necessary, given that the file will be automatically created? (Let me know if I'm missing something) |
native/authoritative-keyserver-id.js | ||
---|---|---|
8 ↗ | (On Diff #36928) | It might help with debugging some issues, or when someone would want to manually change the value (but in that case reading the code might be a better idea). Also, if someone wants to reset / clear the user, they would need to delete the file. |