Paths

Table of Contentst

-
lib/webpack/
-
webpack/
-
shared.cjs
-
web/
-
webpack.config.cjs

[lib][web] Add identity service config to Webpack build
ClosedPublic
Actions

Authored by ashoat on Apr 10 2023, 9:22 AM.

Details

Reviewers

varun
atul
• jon

Commits

rCOMM3c00d53b7747: [lib][web] Add identity service config to Webpack build

Summary

In order to be able to access the identity service config we configure keyserver with in web, we need to include it in the Webpack build.

I initially tried doing this with two separate webpack.DefinePlugin invocations, but they conflicted:

WARNING in DefinePlugin
Conflicting values for 'process.env'

Test Plan

I tested by running a local identity service and patching my checkout with the following: https://gist.github.com/Ashoat/d3bb12e6f10ddda90bb785ff0476ce9a

Note that the identity service returned an error, but the error was received by the client so I think things are working. Identity service error is tracked in ENG-3631

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 10 2023, 9:22 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 10 2023, 9:22 AM

Harbormaster completed remote builds in B18183: Diff 24897.Apr 10 2023, 9:38 AM

ashoat requested review of this revision.Apr 10 2023, 9:38 AM

atul accepted this revision.Apr 10 2023, 10:27 AM

This revision is now accepted and ready to land.Apr 10 2023, 10:27 AM

Closed by commit rCOMM3c00d53b7747: [lib][web] Add identity service config to Webpack build (authored by ashoat). · Explain WhyApr 10 2023, 10:36 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM3c00d53b7747: [lib][web] Add identity service config to Webpack build.

inka mentioned this in D10993: [lib][web][native] Add configurable authoritativeKeyserverID.Feb 8 2024, 7:20 AM

inka mentioned this in rCOMM9c9b9d26a8e6: [lib][web][native] Add configurable authoritativeKeyserverID.Feb 23 2024, 4:34 AM

Revision Contents
Changeset List

Path

Size

lib/

webpack/

shared.cjs

6 lines

web/

webpack.config.cjs

19 lines

Diff 24909

View Options

lib/webpack/shared.cjs

	div.headerContainer {			div.loginContainer {
	flex: 1 1 auto;
	padding: 0 10px;
	}
	div.headerContents {
	display: flex;			display: flex;
	justify-content: space-between;			justify-content: center;
	align-items: center;
	padding-top: 5px;
	padding-bottom: 7px;
	}
	div.actionLinks > * {
	padding-right: 15px;
	color: white;
	font-weight: 300;
	}
	div.actionLinks > *:last-child {
	padding-right: 0;
	}
	header.header h1 {
	color: white;			color: white;
	font-size: 38px;
	}
	header.header {
	padding: 10px 20px;
	border-radius: 20px;
	border: 1px solid white;
	}			}