Page MenuHomePhabricator

[lib][web] Add identity service config to Webpack build
ClosedPublic

Authored by ashoat on Apr 10 2023, 9:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 3, 1:01 PM
Unknown Object (File)
Sun, Jun 30, 4:15 AM
Unknown Object (File)
Sat, Jun 29, 4:01 PM
Unknown Object (File)
Mon, Jun 24, 10:32 AM
Unknown Object (File)
Sun, Jun 23, 2:23 PM
Unknown Object (File)
Tue, Jun 11, 6:56 PM
Unknown Object (File)
Tue, Jun 11, 9:34 AM
Unknown Object (File)
Mon, Jun 10, 4:58 PM
Subscribers

Details

Summary

In order to be able to access the identity service config we configure keyserver with in web, we need to include it in the Webpack build.

I initially tried doing this with two separate webpack.DefinePlugin invocations, but they conflicted:

WARNING in DefinePlugin
Conflicting values for 'process.env'
Test Plan

I tested by running a local identity service and patching my checkout with the following: https://gist.github.com/Ashoat/d3bb12e6f10ddda90bb785ff0476ce9a

Note that the identity service returned an error, but the error was received by the client so I think things are working. Identity service error is tracked in ENG-3631

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable