[lib][web][native] Use real admin username or id when adding a ks
ClosedPublic
Actions

Authored by inka on Mar 8 2024, 3:54 AM.

Details

Reviewers

tomek
michal
ginsu

Commits

rCOMMa4f77daafee9: [lib][web][native] Use real admin username or id when adding a ks

Summary

This was a part of my patch diff D11141, but actually it would make sense to already land this
This partially addresses ENG-6298, becuse if someone is set up with identity, then the real username will be used

Test Plan

Added a keyserver on native, and checked that the keyserver shows up on the list of keyservers with username keyserver<id>

Diff Detail

Repository

rCOMM Comm

Branch

inka/revert_hacks

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Mar 8 2024, 3:54 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 8 2024, 3:54 AM

inka added a reviewer: ginsu.Mar 8 2024, 3:59 AM

Harbormaster completed remote builds in B27403: Diff 37947.Mar 8 2024, 4:23 AM

inka requested review of this revision.Mar 8 2024, 4:23 AM

Code LGTM, in ENG-6298 you mentioned,

The only hack is that if we don't have the user in our user store, we display a fake username. But the id is correct.

Probably would be good to create a followup task to address this new hack

This revision is now accepted and ready to land.Mar 8 2024, 11:36 AM

In D11283#325663, @ginsu wrote:

Code LGTM, in ENG-6298 you mentioned,

The only hack is that if we don't have the user in our user store, we display a fake username. But the id is correct.

Probably would be good to create a followup task to address this new hack

Here is the task: ENG-7191

inka mentioned this in D11141: [IGNORE] Client hacks for testing multiple keyservers.Mar 11 2024, 8:29 AM

Closed by commit rCOMMa4f77daafee9: [lib][web][native] Use real admin username or id when adding a ks (authored by inka). · Explain WhyMar 11 2024, 8:32 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMa4f77daafee9: [lib][web][native] Use real admin username or id when adding a ks.