Page MenuHomePhabricator
Differential D11302

Send keyserverID in web and desktop notifications
ClosedPublic
Actions

Authored by marcin on Mar 11 2024, 9:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 11:09 AM
Unknown Object (File)
Sun, Nov 24, 11:56 PM
Unknown Object (File)
Sun, Nov 24, 1:45 PM
Unknown Object (File)
Nov 16 2024, 5:46 AM
Unknown Object (File)
Nov 16 2024, 4:42 AM
Unknown Object (File)
Nov 16 2024, 4:37 AM
Unknown Object (File)
Nov 16 2024, 3:42 AM
Unknown Object (File)
Nov 16 2024, 2:03 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
Commits
rCOMM3fa1401d8bc9: Send keyserverID in web and desktop notifications
Summary

This differential adds unencrypted keyserverID to web and desktop notification payload. Additionally necessary types are updated.

Test Plan
  1. Flow
  2. Test that notifications aren' broken on web and desktop.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Mar 11 2024, 9:22 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 11 2024, 9:22 AM
marcin added a parent revision: D11235: Add keyserverID to Android and iOS notification payload..Mar 11 2024, 9:33 AM
marcin added a child revision: D11303: Boilerplate for web and desktop to look for keyserverID during notifications session creation and notification decryption.
marcin updated this revision to Diff 38001.Mar 11 2024, 9:35 AM

Rebase to update commit message

marcin edited the summary of this revision. (Show Details)Mar 11 2024, 9:36 AM
Harbormaster completed remote builds in B27449: Diff 37998.Mar 11 2024, 9:38 AM
Harbormaster completed remote builds in B27452: Diff 38001.Mar 11 2024, 9:50 AM
marcin requested review of this revision.Mar 11 2024, 9:50 AM
michal accepted this revision.Mar 12 2024, 8:24 AM
This revision is now accepted and ready to land.Mar 12 2024, 8:24 AM
marcin updated this revision to Diff 38221.Mar 20 2024, 4:16 AM

Rebase before landing

Harbormaster completed remote builds in B27623: Diff 38221.Mar 20 2024, 4:32 AM
Closed by commit rCOMM3fa1401d8bc9: Send keyserverID in web and desktop notifications (authored by marcin). · Explain WhyMar 20 2024, 5:37 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM3fa1401d8bc9: Send keyserverID in web and desktop notifications.

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
19 lines
17 lines
lib/
types/
10 lines

Diff 38001

View Options

keyserver/src/push/crypto.js

Loading...
View Options

keyserver/src/push/send.js

Loading...
View Options

lib/types/notif-types.js

Loading...