Paths

Table of Contentst

Differential D11312

[native] use short form for prekeys
ClosedPublic
Actions

Authored by varun on Mar 12 2024, 1:00 PM.

Tags

None

Referenced Files

	F3564768: D11312.id38158.diff
	Fri, Dec 27, 2:42 PM

	F3564767: D11312.id38031.diff
	Fri, Dec 27, 2:42 PM

	F3564729: D11312.id.diff
	Fri, Dec 27, 2:41 PM

	F3564716: D11312.diff
	Fri, Dec 27, 2:39 PM

	Unknown Object (File)
	Wed, Dec 4, 8:52 PM

	Unknown Object (File)
	Thu, Nov 28, 11:50 PM

	Unknown Object (File)
	Thu, Nov 28, 10:54 PM

	Unknown Object (File)
	Nov 25 2024, 5:33 AM

View All 61 Files

Subscribers

Details

Reviewers

kamil
marcin

Commits

rCOMM3d1844eb73a8: [native] use short form for prekeys

Summary

parse the prekey blob string using folly and then convert the std::string to a rust::String / jsi::String

Test Plan

https://gist.github.com/vdhanan/1b93f4b98a04c1ff0c2c3c7074b4c625

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Mar 12 2024, 1:00 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 12 2024, 1:00 PM

Harbormaster completed remote builds in B27482: Diff 38031.Mar 12 2024, 1:15 PM

varun requested review of this revision.Mar 12 2024, 1:15 PM

varun added a child revision: D11319: [crypto] make sure short format of prekey is expected when creating an outbound session.Mar 13 2024, 5:22 PM

Can you link the diff where you update parsing prekeys when creating a session and land those two together? Now it's not possible to create a session between two native devices.

This revision is now accepted and ready to land.Mar 14 2024, 2:48 AM

In D11312#326574, @kamil wrote:

Can you link the diff where you update parsing prekeys when creating a session and land those two together? Now it's not possible to create a session between two native devices.

I see stack now, sorry!

marcin added inline comments.Mar 14 2024, 9:39 AM

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
587 ↗	(On Diff #38031)	I would add two checks: Check if what we have under `"curve22519"` is folly dynamic object and if `values` doesn't return empty iterator. I my gists that I shared on Linear I didn't do those checks but those gists weren't code intended to run in production. Surround it with `try{}...catch(const folly::json::parse_error &e){}`. In case anything fails we will have more informative errors.

varun added inline comments.Mar 18 2024, 10:27 PM

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
587 ↗	(On Diff #38031)	https://linear.app/comm/issue/ENG-7280/add-checks-to-parseolmprekey

Closed by commit rCOMM3d1844eb73a8: [native] use short form for prekeys (authored by varun). · Explain WhyMar 18 2024, 10:32 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM3d1844eb73a8: [native] use short form for prekeys.

varun mentioned this in D11356: [native] improve error handling in parseOLMPrekeys.Mar 19 2024, 11:53 AM

varun mentioned this in rCOMM528670e7c977: [native] improve error handling in parseOLMPrekeys.Mar 20 2024, 2:33 PM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

23 lines

Diff 38158

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...