Differential D11356

[native] improve error handling in parseOLMPrekeys
ClosedPublic
Actions

Authored by varun on Mar 19 2024, 11:53 AM.

Details

Reviewers

marcin

Commits

rCOMM528670e7c977: [native] improve error handling in parseOLMPrekeys

Summary

addressing feedback from D11312

More info here: https://linear.app/comm/issue/ENG-7280/add-checks-to-parseolmprekey

Test Plan

tested both validateAndGet and validateAndUpload and confirmed both still work as expected. Also passed invalid prekey blobs to parseOLMPrekey to trigger the various exceptions there.

Diff Detail

Repository

rCOMM Comm

Branch

limit1keyserver (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Mar 19 2024, 11:53 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 19 2024, 11:53 AM

Harbormaster completed remote builds in B27607: Diff 38203.Mar 19 2024, 12:08 PM

varun requested review of this revision.Mar 19 2024, 12:08 PM

marcin accepted this revision.Mar 20 2024, 2:48 AM

This revision is now accepted and ready to land.Mar 20 2024, 2:48 AM

Closed by commit rCOMM528670e7c977: [native] improve error handling in parseOLMPrekeys (authored by varun). · Explain WhyMar 20 2024, 2:33 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM528670e7c977: [native] improve error handling in parseOLMPrekeys.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

64 lines

Diff 38203

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[native] improve error handling in parseOLMPrekeysClosedPublicActions