Page MenuHomePhabricator
Differential D11356

[native] improve error handling in parseOLMPrekeys
ClosedPublic
Actions

Authored by varun on Mar 19 2024, 11:53 AM.
Tags
None
Referenced Files
F1748977: D11356.diff
Mon, May 13, 7:32 PM
Unknown Object (File)
Thu, May 2, 10:06 PM
Unknown Object (File)
Thu, Apr 25, 12:49 PM
Unknown Object (File)
Thu, Apr 25, 12:48 PM
Unknown Object (File)
Apr 12 2024, 3:29 PM
Unknown Object (File)
Apr 10 2024, 3:38 PM
Unknown Object (File)
Apr 3 2024, 8:47 PM
Unknown Object (File)
Apr 2 2024, 6:21 AM
View All 14 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
Commits
rCOMM528670e7c977: [native] improve error handling in parseOLMPrekeys
Summary

addressing feedback from D11312

More info here: https://linear.app/comm/issue/ENG-7280/add-checks-to-parseolmprekey

Test Plan

tested both validateAndGet and validateAndUpload and confirmed both still work as expected. Also passed invalid prekey blobs to parseOLMPrekey to trigger the various exceptions there.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
64 lines

Diff 38241

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...