Page MenuHomePhabricator
Differential D11365

[lib] Fix auth with non authoritative keyserver error
ClosedPublic
Actions

Authored by inka on Mar 21 2024, 1:11 AM.
Tags
None
Referenced Files
F3892934: D11365.id38243.diff
Sat, Jan 25, 1:02 AM
F3891821: D11365.diff
Fri, Jan 24, 8:57 PM
Unknown Object (File)
Thu, Jan 23, 1:08 PM
Unknown Object (File)
Thu, Jan 23, 1:07 PM
Unknown Object (File)
Thu, Jan 23, 1:07 PM
Unknown Object (File)
Thu, Jan 23, 12:58 PM
Unknown Object (File)
Mon, Jan 20, 3:27 AM
Unknown Object (File)
Mon, Jan 20, 3:27 AM
View All 92 Files
Subscribers
ashoat

Details

Reviewers
tomek
michal
kamil
Commits
rCOMMeb9e23ede082: [lib] Fix auth with non authoritative keyserver error
Summary

This fixes a problem described in this comment: https://linear.app/comm/issue/ENG-7312/terms-of-service-modal-popping-up-unexpectedly#comment-64686c0a
We can auth with a different keyserver than the authoritative one, so responses[authoritativeKeyserverID()] may not exist

Test Plan

Reading the code - since responses[authoritativeKeyserverID()] may not exist, we have to do this. We also do this for currentUserInfo a couple of lines higher

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
actions/
2 lines

Diff 38243

View Options

lib/actions/user-actions.js

Loading...