Page MenuHomePhabricator

[keyserver] Construct a new TunnelbrokerSocket when one closes
ClosedPublic

Authored by ashoat on Mar 26 2024, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 12:59 AM
Unknown Object (File)
Wed, Nov 13, 12:04 AM
Unknown Object (File)
Wed, Nov 13, 12:04 AM
Unknown Object (File)
Wed, Nov 13, 12:04 AM
Unknown Object (File)
Tue, Nov 12, 10:22 PM
Unknown Object (File)
Fri, Nov 8, 10:07 PM
Unknown Object (File)
Fri, Nov 1, 9:52 PM
Unknown Object (File)
Fri, Nov 1, 9:52 PM
Subscribers

Details

Summary

This resolves ENG-4924, and should address ENG-7318 as well.

Depends on D11391

Test Plan

I let the connection go away when my laptop went to sleep, and confirmed it was recreated after it was woken up

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/tunnelbroker
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil added inline comments.
keyserver/src/socket/tunnelbroker.js
49 ↗(On Diff #38351)

I would put 3000 to a const with a descriptive name, but probably this is also fine

This revision is now accepted and ready to land.Mar 27 2024, 12:35 AM

Add a constant for reconnect delay. Also add a similar constant for the similar logic in lib/socket/socket.react.js

This revision was landed with ongoing or failed builds.Mar 27 2024, 5:25 AM
This revision was automatically updated to reflect the committed changes.