Page MenuHomePhabricator
Differential D11392

[keyserver] Construct a new TunnelbrokerSocket when one closes
ClosedPublic
Actions

Authored by ashoat on Mar 26 2024, 8:25 PM.
Tags
None
Referenced Files
F1769205: D11392.diff
Wed, May 15, 9:16 AM
Unknown Object (File)
Mon, Apr 29, 7:09 AM
Unknown Object (File)
Apr 14 2024, 7:43 PM
Unknown Object (File)
Apr 14 2024, 7:43 PM
Unknown Object (File)
Apr 14 2024, 7:43 PM
Unknown Object (File)
Apr 14 2024, 7:43 PM
Unknown Object (File)
Apr 14 2024, 7:42 PM
Unknown Object (File)
Apr 6 2024, 1:12 AM
View All 11 Files
Subscribers
tomek

Details

Reviewers
kamil
marcin
Commits
rCOMM2a37b6defc5b: [keyserver] Construct a new TunnelbrokerSocket when one closes
Summary

This resolves ENG-4924, and should address ENG-7318 as well.

Depends on D11391

Test Plan

I let the connection go away when my laptop went to sleep, and confirmed it was recreated after it was woken up

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/tunnelbroker
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 26 2024, 8:25 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 26 2024, 8:25 PM
Harbormaster completed remote builds in B27694: Diff 38351.Mar 26 2024, 8:40 PM
ashoat requested review of this revision.Mar 26 2024, 8:40 PM
kamil accepted this revision.Mar 27 2024, 12:35 AM
kamil added inline comments.
keyserver/src/socket/tunnelbroker.js
49 ↗(On Diff #38351)

I would put 3000 to a const with a descriptive name, but probably this is also fine

This revision is now accepted and ready to land.Mar 27 2024, 12:35 AM
ashoat updated this revision to Diff 38362.Mar 27 2024, 5:19 AM

Add a constant for reconnect delay. Also add a similar constant for the similar logic in lib/socket/socket.react.js

This revision was landed with ongoing or failed builds.Mar 27 2024, 5:25 AM
Closed by commit rCOMM2a37b6defc5b: [keyserver] Construct a new TunnelbrokerSocket when one closes (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM2a37b6defc5b: [keyserver] Construct a new TunnelbrokerSocket when one closes.
Harbormaster completed remote builds in B27701: Diff 38362.Mar 27 2024, 5:34 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
7 lines
10 lines
lib/
shared/
8 lines
socket/
3 lines

Diff 38362

View Options

keyserver/src/socket/tunnelbroker-socket.js

Loading...
View Options

keyserver/src/socket/tunnelbroker.js

Loading...
View Options

lib/shared/timeouts.js

Loading...
View Options

lib/socket/socket.react.js

Loading...