Page MenuHomePhabricator
Differential D11515

[keyserver] expose getFarcasterUsers client method to JS on keyserver
ClosedPublic
Actions

Authored by varun on Apr 1 2024, 2:59 PM.
Tags
None
Referenced Files
F3401882: D11515.id38816.diff
Mon, Dec 2, 2:25 PM
F3401476: D11515.diff
Mon, Dec 2, 12:24 PM
Unknown Object (File)
Sun, Nov 3, 8:03 AM
Unknown Object (File)
Oct 12 2024, 8:06 PM
Unknown Object (File)
Oct 12 2024, 8:06 PM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Oct 12 2024, 8:05 PM
Unknown Object (File)
Oct 2 2024, 11:41 AM
View All 43 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
bartek
Commits
rCOMMd36ab4dcb7f8: [keyserver] expose getFarcasterUsers client method to JS on keyserver
Summary

@atul mentioned we need to call getFarcasterUsers from the keyserver, so this code makes that possible.

Test Plan

https://gist.github.com/vdhanan/0a0498c9e672d44e0e51331c78510f80

Diff Detail

Repository
rCOMM Comm
Branch
delete-user (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Apr 1 2024, 2:59 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 1 2024, 2:59 PM
Harbormaster completed remote builds in B27899: Diff 38641.Apr 1 2024, 3:15 PM
varun requested review of this revision.Apr 1 2024, 3:15 PM
atul accepted this revision.Apr 1 2024, 8:21 PM
varun added inline comments.Apr 2 2024, 12:06 PM
keyserver/addons/rust-node-addon/src/identity_client/get_farcaster_users.rs
35

i'll add a comment here and in lib/types/identity-service-types.js to keep the FarcasterUser types in sync

bartek accepted this revision.Apr 2 2024, 10:52 PM
This revision is now accepted and ready to land.Apr 2 2024, 10:52 PM
Closed by commit rCOMMd36ab4dcb7f8: [keyserver] expose getFarcasterUsers client method to JS on keyserver (authored by varun). · Explain WhyApr 4 2024, 6:42 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMd36ab4dcb7f8: [keyserver] expose getFarcasterUsers client method to JS on keyserver.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
8 lines
src/
identity_client/
41 lines
1 line

Diff 38641

View Options

keyserver/addons/rust-node-addon/rust-binding-types.js

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/get_farcaster_users.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...