Page MenuHomePhabricator

[native] Patch react-native to avoid FlatList this.props error
ClosedPublic

Authored by ashoat on Apr 2 2024, 1:37 PM.
Tags
None
Referenced Files
F3356066: D11527.id38679.diff
Sat, Nov 23, 4:42 PM
F3355423: D11527.diff
Sat, Nov 23, 2:30 PM
Unknown Object (File)
Tue, Nov 12, 10:39 PM
Unknown Object (File)
Tue, Nov 12, 10:39 PM
Unknown Object (File)
Tue, Nov 12, 10:39 PM
Unknown Object (File)
Tue, Nov 12, 10:38 PM
Unknown Object (File)
Tue, Nov 12, 9:27 PM
Unknown Object (File)
Fri, Nov 1, 9:56 PM
Subscribers

Details

Summary

This solves ENG-7635, at least temporarily. It looks like it's this GitHub issue, first introduced by this change.

People on the GitHub issue have several suggestions:

  1. This change
  2. Removing @babel/plugin-transform-private-methods, which we could consider if we remove the private method uses in the transitive dependency that necessitates its introduction initially
  3. Adding a babel plugin somewhere that strips Flow types. I'll consider this one as I continue investigating
Test Plan

Confirm that the issue goes away after resetting the Metro cache (yarn dev -c) and refreshing the app

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat published this revision for review.Apr 2 2024, 1:37 PM
This revision is now accepted and ready to land.Apr 2 2024, 1:38 PM

Actually looks like the right solution (that got landed to React Native) is this

Will wait on some CI builds and then land

This revision was landed with ongoing or failed builds.Apr 2 2024, 1:55 PM
This revision was automatically updated to reflect the committed changes.