[web][native] Refactor reset state logic in reducers
ClosedPublic
Actions

Authored by tomek on Apr 3 2024, 3:27 AM.

Details

Reviewers

kamil
inka
varun

Commits

rCOMM30b805a54fd1: [web][native] Refactor reset state logic in reducers

Summary

This refactoring shouldn't affect the logic. The purpose is to simplify the code so that we reset the state in a single place - it makes the following diff easier to understand.

https://linear.app/comm/issue/ENG-7075/clear-redux-state-only-when-current-user-id-changes

Test Plan

Checked if logging out clears the Redux state.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Apr 3 2024, 3:27 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 3 2024, 3:27 AM

Harbormaster completed remote builds in B27935: Diff 38714.Apr 3 2024, 3:43 AM

tomek requested review of this revision.Apr 3 2024, 3:43 AM

tomek added a child revision: D11533: [web][native] Reset the state iff current user ID changes.Apr 3 2024, 4:23 AM

inka accepted this revision.Apr 4 2024, 3:20 AM

This revision is now accepted and ready to land.Apr 4 2024, 3:20 AM

Closed by commit rCOMM30b805a54fd1: [web][native] Refactor reset state logic in reducers (authored by tomek). · Explain WhyApr 11 2024, 5:38 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM30b805a54fd1: [web][native] Refactor reset state logic in reducers.

Revision Contents
Changeset List

Path

Size

native/

redux/

redux-setup.js

68 lines

web/

redux/

redux-setup.js

53 lines

Diff 38714

View Options

native/redux/redux-setup.js