Page MenuHomePhabricator
Differential D11682

[native] introduce screen options to tag farcaster channel stack navigator
ClosedPublic
Actions

Authored by ginsu on Apr 17 2024, 11:04 PM.
Tags
None
Referenced Files
F3383245: D11682.id39206.diff
Thu, Nov 28, 2:31 PM
F3382918: D11682.diff
Thu, Nov 28, 12:42 PM
Unknown Object (File)
Sun, Nov 3, 7:29 AM
Unknown Object (File)
Oct 12 2024, 10:04 PM
Unknown Object (File)
Oct 12 2024, 10:03 PM
Unknown Object (File)
Oct 12 2024, 10:03 PM
Unknown Object (File)
Oct 12 2024, 10:03 PM
Unknown Object (File)
Oct 9 2024, 1:07 PM
View All 45 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
ashoat
Commits
rCOMM409e47a1b60b: [native] introduce screen options to tag farcaster channel stack navigator
Summary

This diff adds the screen options to the TagFarcasterChannelNavigator and the TagFarcasterChannel screen to match the UI/UX in the other community action screens

Linear task: https://linear.app/comm/issue/ENG-7540/introduce-navigational-logic-for-tagfarcasterchannelmodal

Depends on D11662

Test Plan

Please see the demo video below (the other UI elements in the TagFarcasterChannel will be introduced in the next diff)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 17 2024, 11:04 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 17 2024, 11:04 PM
ginsu edited the summary of this revision. (Show Details)Apr 17 2024, 11:10 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
ginsu attached a referenced file: F1567055: Screen Recording 2024-04-18 at 2.07.54 AM.mov. (Show Details)
ginsu added a reviewer: ashoat.Apr 17 2024, 11:16 PM

Making @ashoat a blocking reviewer since this diff introduces copy changes

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-navigator.react.js
33

This copy needs to be reviewed

Harbormaster completed remote builds in B28282: Diff 39206.Apr 17 2024, 11:21 PM
ginsu requested review of this revision.Apr 17 2024, 11:21 PM
ginsu added a child revision: D11683: [native] implement UI for selecting a farcaster channel.Apr 17 2024, 11:23 PM
ashoat accepted this revision.Apr 18 2024, 11:31 AM
This revision is now accepted and ready to land.Apr 18 2024, 11:31 AM
Closed by commit rCOMM409e47a1b60b: [native] introduce screen options to tag farcaster channel stack navigator (authored by ginsu). · Explain WhyApr 18 2024, 12:06 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM409e47a1b60b: [native] introduce screen options to tag farcaster channel stack navigator.

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
27 lines

Diff 39206

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-navigator.react.js

Loading...