Page MenuHomePhabricator
Differential D11702

Remove unecessary SQLite initialization from CommHybrid
ClosedPublic
Actions

Authored by marcin on Apr 19 2024, 9:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 12:39 PM
Unknown Object (File)
Mon, Nov 25, 12:26 PM
Unknown Object (File)
Mon, Nov 25, 9:46 AM
Unknown Object (File)
Fri, Nov 8, 10:35 PM
Unknown Object (File)
Fri, Nov 8, 1:41 PM
Unknown Object (File)
Fri, Nov 8, 7:14 AM
Unknown Object (File)
Fri, Nov 8, 7:14 AM
Unknown Object (File)
Fri, Nov 8, 7:14 AM
View All 60 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
tomek
Commits
rCOMMfaf8cda7751a: Remove unecessary SQLite initialization from CommHybrid
Summary

This differential removes unnecessary and potentially buggy SQLite initialization from CommHybrid. The context is here:
https://linear.app/comm/issue/ENG-7700/reconsider-double-sqlitequeryexecutorinitialize-calls-on-android

Test Plan

Uninstall and reinstall Android app a couple of times. Ensure each time app works correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Apr 19 2024, 9:48 AM
marcin added 1 blocking reviewer(s): kamil.Apr 19 2024, 9:49 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2024, 9:58 AM
Harbormaster failed remote builds in B28331: Diff 39290!
Harbormaster completed remote builds in B28331: Diff 39290.Apr 19 2024, 10:08 AM
marcin requested review of this revision.Apr 19 2024, 10:08 AM
ashoat accepted this revision.Apr 19 2024, 12:02 PM

Nice to clean up the additionalParameters stuff

kamil accepted this revision.Apr 22 2024, 3:40 AM
This revision is now accepted and ready to land.Apr 22 2024, 3:40 AM
marcin updated this revision to Diff 39337.Apr 22 2024, 5:09 AM

Rebase before landing

Harbormaster completed remote builds in B28353: Diff 39337.Apr 22 2024, 5:24 AM
Closed by commit rCOMMfaf8cda7751a: Remove unecessary SQLite initialization from CommHybrid (authored by marcin). · Explain WhyApr 22 2024, 5:33 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMfaf8cda7751a: Remove unecessary SQLite initialization from CommHybrid.
ashoat mentioned this in D12624: [native] Add CommSecureStore.set on main thread to resolve race with DB thread.Jun 29 2024, 12:30 PM
ashoat mentioned this in rCOMM4386aef2000d: [native] Add CommSecureStore.get on main thread to resolve race with DB thread.Jun 29 2024, 12:55 PM

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
cpp/
12 lines
main/
java/
app/
comm/
android/
fbjni/
12 lines

Diff 39338

View Options

native/android/app/src/cpp/jsiInstaller.cpp

Loading...
View Options

native/android/app/src/main/java/app/comm/android/fbjni/CommHybrid.java

Loading...