Paths

Table of Contentst

Remove unecessary SQLite initialization from CommHybrid
ClosedPublic
Actions

Authored by marcin on Apr 19 2024, 9:48 AM.

Details

Reviewers

kamil
ashoat
tomek

Commits

rCOMMfaf8cda7751a: Remove unecessary SQLite initialization from CommHybrid

Summary

This differential removes unnecessary and potentially buggy SQLite initialization from CommHybrid. The context is here:
https://linear.app/comm/issue/ENG-7700/reconsider-double-sqlitequeryexecutorinitialize-calls-on-android

Test Plan

Uninstall and reinstall Android app a couple of times. Ensure each time app works correctly.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Apr 19 2024, 9:48 AM

marcin added 1 blocking reviewer(s): kamil.Apr 19 2024, 9:49 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2024, 9:58 AM

Harbormaster failed remote builds in B28331: Diff 39290!

Harbormaster completed remote builds in B28331: Diff 39290.Apr 19 2024, 10:08 AM

marcin requested review of this revision.Apr 19 2024, 10:08 AM

Nice to clean up the additionalParameters stuff

kamil accepted this revision.Apr 22 2024, 3:40 AM

This revision is now accepted and ready to land.Apr 22 2024, 3:40 AM

Rebase before landing

Harbormaster completed remote builds in B28353: Diff 39337.Apr 22 2024, 5:24 AM

Closed by commit rCOMMfaf8cda7751a: Remove unecessary SQLite initialization from CommHybrid (authored by marcin). · Explain WhyApr 22 2024, 5:33 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMfaf8cda7751a: Remove unecessary SQLite initialization from CommHybrid.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

cpp/

jsiInstaller.cpp

12 lines

main/

java/

app/

comm/

android/

fbjni/

CommHybrid.java

12 lines

Diff 39338

View Options

native/android/app/src/cpp/jsiInstaller.cpp