Page MenuHomePhabricator
Differential D11744

[identity] add env var conditional json tracing
ClosedPublic
Actions

Authored by will on Apr 23 2024, 11:40 AM.
Tags
None
Referenced Files
F3298648: D11744.id39526.diff
Sun, Nov 17, 7:40 AM
Unknown Object (File)
Tue, Nov 12, 2:39 PM
Unknown Object (File)
Tue, Nov 12, 2:30 PM
Unknown Object (File)
Tue, Nov 12, 2:26 PM
Unknown Object (File)
Tue, Nov 12, 1:00 PM
Unknown Object (File)
Tue, Nov 12, 10:06 AM
Unknown Object (File)
Tue, Nov 12, 9:20 AM
Unknown Object (File)
Oct 12 2024, 2:59 PM
View All 73 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM0b3bd2ef4147: [identity] add env var conditional json tracing
Summary

Initializes environment with json tracing if the COMM_SERVICES_USE_JSON_LOGS environmental variable is set to "true"

Test Plan

cargo check. Runs with json logs when I set env var to "true" and regular logs when "false".

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Apr 23 2024, 11:40 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 23 2024, 11:40 AM
Harbormaster completed remote builds in B28416: Diff 39421.Apr 23 2024, 12:01 PM
will requested review of this revision.Apr 23 2024, 12:01 PM
bartek accepted this revision.Apr 24 2024, 2:19 AM

As a follow-up, we probably want to extract this logic to comm-lib because finally I'd love to see all services using JSON logs in AWS

This revision is now accepted and ready to land.Apr 24 2024, 2:19 AM
will updated this revision to Diff 39525.Apr 25 2024, 9:18 PM

rebase

will updated this revision to Diff 39526.Apr 25 2024, 9:25 PM

rebase

This revision was landed with ongoing or failed builds.Apr 25 2024, 9:28 PM
Closed by commit rCOMM0b3bd2ef4147: [identity] add env var conditional json tracing (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM0b3bd2ef4147: [identity] add env var conditional json tracing.
Harbormaster completed remote builds in B28493: Diff 39525.Apr 25 2024, 9:37 PM
Harbormaster completed remote builds in B28494: Diff 39526.Apr 25 2024, 9:40 PM

Revision Contents
Changeset List

PathSize
services/
identity/
2 lines
src/
4 lines
20 lines

Diff 39421

View Options

services/identity/Cargo.lock

Loading...
View Options

services/identity/Cargo.toml

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/main.rs

Loading...