Paths

Table of Contentst

Differential D11760

[web] Fix missing relationship buttons
ClosedPublic
Actions

Authored by inka on Apr 24 2024, 7:32 AM.

Tags

None

Referenced Files

	F3753194: D11760.id39495.diff
	Fri, Jan 10, 1:15 AM

	F3752425: D11760.id39440.diff
	Fri, Jan 10, 12:39 AM

	F3747639: D11760.diff
	Thu, Jan 9, 7:23 PM

	Unknown Object (File)
	Wed, Dec 25, 7:08 PM

	Unknown Object (File)
	Wed, Dec 25, 7:08 PM

	Unknown Object (File)
	Wed, Dec 25, 7:08 PM

	Unknown Object (File)
	Wed, Dec 25, 7:07 PM

	Unknown Object (File)
	Wed, Dec 25, 7:07 PM

View All 61 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMMfa2cd2e93e24: [web] Fix missing relationship buttons

Summary

issue: ENG-7486
We might not have user infos in our UserStore, if we don't have any relationship with them. But we can extract them from the pending thread infos. useRelationshipPrompt takes pendingPersonalThreadUserInfo as an argument, and uses it if the user infos are indeed not present in the store.

Test Plan

Tested that the relationship buttons are present and work correctly

Diff Detail

Repository

Branch

inka/may2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Apr 24 2024, 7:32 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 24 2024, 7:32 AM

Harbormaster completed remote builds in B28433: Diff 39440.Apr 24 2024, 7:51 AM

inka requested review of this revision.Apr 24 2024, 7:51 AM

ashoat added inline comments.Apr 24 2024, 6:32 PM

web/chat/chat-message-list.react.js
322–325	Is there a risk in an index out-of-bounds error here?

Make the code safer

Harbormaster completed remote builds in B28465: Diff 39485.Apr 25 2024, 6:09 AM

Is native also affected by this bug?

This revision is now accepted and ready to land.Apr 25 2024, 7:17 AM

In D11760#337835, @tomek wrote:

Is native also affected by this bug?

No, native handles this differently

Closed by commit rCOMMfa2cd2e93e24: [web] Fix missing relationship buttons (authored by inka). · Explain WhyApr 25 2024, 8:46 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMfa2cd2e93e24: [web] Fix missing relationship buttons.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-message-list.react.js

26 lines

relationship-prompt/

relationship-prompt.js

13 lines

Diff 39440

web/chat/chat-message-list.react.js

Loading...

web/chat/relationship-prompt/relationship-prompt.js

Loading...