We want to confirm message after processing it.
Depends on D11732
Details
Details
Add sleep and make sure message is confirmed after message was processed.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- land
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 273 ↗ | (On Diff #39394) | we get the incorrect message - so we just confirm it so Tunnelbroker will remove it from it's queue |
| 279 ↗ | (On Diff #39394) | invalid Tunnelbroker message - this could happen when the client has an older version and is not capable of processing recently added new messages, we can consider informing the user to somehow update the app, but for now, confirming is the best we can do |
| 290 ↗ | (On Diff #39394) | peerToPeerMessageHandler is designed so that it will not throw, we confirm regardless of success or error while processing |
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 279 ↗ | (On Diff #39394) | Should we add an in-code comment describing this scenario? |
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 290 ↗ | (On Diff #39394) | What if socket.current is falsy? When can this happen? Should we try confirming again after it becomes truthy? |
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 290 ↗ | (On Diff #39394) | socket.current is falsy then this code shouldn't be executed as it's called only as a response to the received message - when socket.current is defined, ? is only to satisfy flow |
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 290 ↗ | (On Diff #39394) | that's not true - I need to update this diff, ignore my comment |
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 310–311 ↗ | (On Diff #39646) | Should we also check localSocketSessionCounter === socketSessionCounter.current here? |
Comment Actions
add missing check
| lib/tunnelbroker/tunnelbroker-context.js | ||
|---|---|---|
| 310–311 ↗ | (On Diff #39646) | yes, thanks fo catchinng |