Page MenuHomePhabricator
Differential D11732

[lib] handle Tunnelbroker messages sequentially
ClosedPublic
Actions

Authored by kamil on Mon, Apr 22, 5:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 9:13 PM
Unknown Object (File)
Thu, May 2, 6:54 PM
Unknown Object (File)
Thu, May 2, 12:34 PM
Unknown Object (File)
Thu, May 2, 1:25 AM
Unknown Object (File)
Sat, Apr 27, 9:02 PM
Unknown Object (File)
Sat, Apr 27, 2:12 PM
Unknown Object (File)
Thu, Apr 25, 10:05 AM
Unknown Object (File)
Tue, Apr 23, 1:50 AM
View All 10 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMMa1a94909af73: [lib] handle Tunnelbroker messages sequentially
Summary

This is similar approach to what's implemented on web worker: https://phab.comm.dev/D11299

Test Plan

Connect two devices, send message trough Tunnelbroker and add sleep to processing, make sure each messages are processed in sequence.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Apr 22, 5:57 PM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Apr 22, 5:57 PM
Harbormaster completed remote builds in B28389: Diff 39383.Mon, Apr 22, 6:13 PM
kamil added a child revision: D11737: [lib] confirm Tunnelbroker messages after processing.Tue, Apr 23, 4:27 AM
kamil published this revision for review.Tue, Apr 23, 6:43 AM
tomek accepted this revision.Mon, Apr 29, 12:26 AM
This revision is now accepted and ready to land.Mon, Apr 29, 12:26 AM
tomek added inline comments.Mon, Apr 29, 12:30 AM
lib/tunnelbroker/tunnelbroker-context.js
282–289 ↗(On Diff #39383)

Wondering how this would behave if one of the calls to peerToPeerMessageHandler fails.

kamil added inline comments.Mon, Apr 29, 2:47 AM
lib/tunnelbroker/tunnelbroker-context.js
282–289 ↗(On Diff #39383)

peerToPeerMessageHandler should fail/throw - to confirm message to TB regardless of success or error while processing

kamil updated this revision to Diff 39645.Mon, Apr 29, 4:53 AM

refactor

kamil requested review of this revision.Mon, Apr 29, 4:57 AM
Harbormaster completed remote builds in B28571: Diff 39645.Mon, Apr 29, 5:09 AM
tomek accepted this revision.Mon, Apr 29, 5:31 AM
This revision is now accepted and ready to land.Mon, Apr 29, 5:31 AM
Closed by commit rCOMMa1a94909af73: [lib] handle Tunnelbroker messages sequentially (authored by kamil). · Explain WhyMon, Apr 29, 6:04 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa1a94909af73: [lib] handle Tunnelbroker messages sequentially.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
32 lines

Diff 39652

View Options

lib/tunnelbroker/tunnelbroker-context.js

Loading...