[identity] remove duplicate debug log for HTTP requests
ClosedPublic
Actions

Authored by will on Apr 30 2024, 8:21 PM.

Details

Reviewers

varun
bartek

Commits

rCOMM3e1a4ed50f83: [identity] remove duplicate debug log for HTTP requests

Summary

Missed on original implementation. We have two identical debug logs for incoming HTTP requests

Test Plan

cargo check

Diff Detail

Repository

rCOMM Comm

Branch

cleanup_logs

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Apr 30 2024, 8:21 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 30 2024, 8:21 PM

Harbormaster completed remote builds in B28613: Diff 39717.Apr 30 2024, 8:39 PM

will requested review of this revision.Apr 30 2024, 8:39 PM

varun accepted this revision.Apr 30 2024, 8:41 PM

varun added inline comments.

services/identity/src/websockets/mod.rs
80	don't we want to log this before we potentially return in the above if statement?

This revision is now accepted and ready to land.Apr 30 2024, 8:41 PM

will added inline comments.May 1 2024, 3:47 PM

services/identity/src/websockets/mod.rs
80	Fair point. I'll move the below debug log and land

review feedback

Harbormaster completed remote builds in B28614: Diff 39718.May 1 2024, 4:08 PM

Closed by commit rCOMM3e1a4ed50f83: [identity] remove duplicate debug log for HTTP requests. · Explain WhyMay 1 2024, 4:12 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM3e1a4ed50f83: [identity] remove duplicate debug log for HTTP requests.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

websockets/

mod.rs

5 lines

Diff 39717

View Options

services/identity/src/websockets/mod.rs

[identity] remove duplicate debug log for HTTP requestsClosedPublicActions