Page MenuHomePhabricator
Differential D11867

[native] Allow LOG_IN ReactNav action to dismiss RegistrationTerms
ClosedPublic
Actions

Authored by ashoat on May 3 2024, 12:59 PM.
Tags
None
Referenced Files
F3396950: D11867.diff
Sun, Dec 1, 3:39 PM
Unknown Object (File)
Fri, Nov 29, 3:53 PM
Unknown Object (File)
Fri, Nov 29, 2:43 PM
Unknown Object (File)
Thu, Nov 28, 9:04 AM
Unknown Object (File)
Mon, Nov 25, 7:05 AM
Unknown Object (File)
Mon, Nov 25, 6:58 AM
Unknown Object (File)
Sun, Nov 24, 9:55 PM
Unknown Object (File)
Thu, Nov 14, 8:02 PM
View All Files
Subscribers
tomek

Details

Reviewers
ginsu
Commits
rCOMM16c254000a64: [native] Allow LOG_IN ReactNav action to dismiss RegistrationTerms
Summary

During the registration server call, we want to prevent RegistrationTerms from being dismissed so that eg. a user pressing the Android hardware back button won't make it "go back".

However, we want to allow the LOG_IN ReactNav action to dismiss RegistrationTerms, so that when registration concludes the user is visibly logged in.

This diff solves ENG-8037 by differentiating the LOG_IN action.

Test Plan

Make sure registration flow logs the user in at the end

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
account/
registration/
5 lines

Diff 39765

View Options

native/account/registration/registration-terms.react.js

Loading...