[native] disable navigation in `RestoreBackupScreen`
ClosedPublic
Actions

Authored by kamil on Feb 24 2025, 6:35 AM.

Details

Reviewers

tomek
bartek
angelika

Commits

rCOMM5e28325d4ed2: [native] disable navigation in `RestoreBackupScreen`

Summary

Part of ENG-10240.

Using the same approach as for Register account screen.

Test Plan

It is not possible to get back using header
It is not possible to use system back button
Swipe back gesture is not working
After restore user is navigated to app
After failure and confirming alert user is navigated back to credentials

Tested on physical iOS and physical Android.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Feb 24 2025, 6:35 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 24 2025, 6:35 AM

kamil edited the summary of this revision. (Show Details)Feb 24 2025, 6:36 AM

kamil added a child revision: D14397: [native] prevent leaving restore screen when falling back to v1.

kamil published this revision for review.Feb 24 2025, 6:48 AM

tomek accepted this revision.Feb 24 2025, 8:33 AM

tomek added inline comments.

native/account/restore-backup-screen.react.js
54–56 ↗	(On Diff #47232)	Why do we have to filter out some actions? In the linked code from the registration flow, we don't have to do any filtering.

This revision is now accepted and ready to land.Feb 24 2025, 8:33 AM

Just confirming – is this screen only used when the restore is in-progress? If the button to start is on this screen too, we might want to only prevent the user from navigating away after the button is pressed

native/account/restore-backup-screen.react.js
54–56 ↗	(On Diff #47232)	Presumably this is so a successful login can still dismiss this screen

In D14398#400120, @ashoat wrote:

Just confirming – is this screen only used when the restore is in-progress?

Yes

If the button to start is on this screen too, we might want to only prevent the user from navigating away after the button is pressed

The button is on a different screen and also has some async action prior to navigating to this screen where we should prevent user from navigating away, I handled this in the next diff in the stack - D14397.

native/account/restore-backup-screen.react.js
54–56 ↗	(On Diff #47232)	Why do we have to filter out some actions? In the linked code from the registration flow, we don't have to do any filtering. We do, see this line. Presumably this is so a successful login can still dismiss this screen Exactly, according to D11867

bartek accepted this revision.Feb 25 2025, 1:28 AM

This revision was landed with ongoing or failed builds.Feb 25 2025, 4:34 AM

Closed by commit rCOMM5e28325d4ed2: [native] disable navigation in `RestoreBackupScreen` (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM5e28325d4ed2: [native] disable navigation in `RestoreBackupScreen`.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

auth-navigator.react.js

6 lines

restore-backup-screen.react.js

8 lines

Diff 47269

View Options

native/account/registration/auth-navigator.react.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines	size_t decryptedSize = ::olm_decrypt(
decryptedMessage.data(),		decryptedMessage.data(),
decryptedMessage.size());		decryptedMessage.size());
if (decryptedSize == -1) {		if (decryptedSize == -1) {
throw std::runtime_error{		throw std::runtime_error{
"error decrypt => " + std::string{::olm_session_last_error(session)} +		"error decrypt => " + std::string{::olm_session_last_error(session)} +
". Hash: " +		". Hash: " +
std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};		std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};
}		}
return std::string{(char *)decryptedMessage.data(), decryptedSize};		return std::string{decryptedMessage.begin(), decryptedMessage.end()};
}		}

std::string Session::decryptSequential(EncryptedData &encryptedData) {		std::string Session::decryptSequential(EncryptedData &encryptedData) {
OlmSession *session = this->getOlmSession();		OlmSession *session = this->getOlmSession();

OlmBuffer utilityBuffer(::olm_utility_size());		OlmBuffer utilityBuffer(::olm_utility_size());
OlmUtility *olmUtility = ::olm_utility(utilityBuffer.data());		OlmUtility *olmUtility = ::olm_utility(utilityBuffer.data());

Show All 28 Lines	size_t decryptedSize = ::olm_decrypt_sequential(
decryptedMessage.data(),		decryptedMessage.data(),
decryptedMessage.size());		decryptedMessage.size());
if (decryptedSize == -1) {		if (decryptedSize == -1) {
throw std::runtime_error{		throw std::runtime_error{
"error decrypt_sequential => " +		"error decrypt_sequential => " +
std::string{::olm_session_last_error(session)} + ". Hash: " +		std::string{::olm_session_last_error(session)} + ". Hash: " +
std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};		std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};
}		}
return std::string{(char *)decryptedMessage.data(), decryptedSize};		return std::string{decryptedMessage.begin(), decryptedMessage.end()};
}		}

int Session::getVersion() {		int Session::getVersion() {
return this->version;		return this->version;
}		}

void Session::setVersion(int newVersion) {		void Session::setVersion(int newVersion) {
this->version = newVersion;		this->version = newVersion;
}		}

} // namespace crypto		} // namespace crypto
} // namespace comm		} // namespace comm