Page MenuHomePhabricator
Differential D11843

[native] add test button to create initial peer list
ClosedPublic
Actions

Authored by kamil on Apr 30 2024, 6:54 AM.
Tags
None
Referenced Files
F3185553: D11843.diff
Fri, Nov 8, 12:59 PM
F3182875: D11843.id.diff
Fri, Nov 8, 8:08 AM
F3181416: D11843.id.diff
Fri, Nov 8, 6:16 AM
Unknown Object (File)
Thu, Nov 7, 3:34 PM
Unknown Object (File)
Sat, Oct 19, 2:48 AM
Unknown Object (File)
Sun, Oct 13, 11:21 PM
Unknown Object (File)
Sat, Oct 12, 11:13 PM
Unknown Object (File)
Thu, Oct 10, 7:53 PM
View All 60 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMMd2a13263d231: [native] add test button to create initial peer list
Summary

Before Identity launch, there isn't make any sense to run this migration, right now adding this only for testing purposes but the code can be reused.

Depends on D11842

Test Plan
  1. Test is store was properly populated
  2. Test is persisting works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Apr 30 2024, 6:54 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptApr 30 2024, 6:54 AM
Harbormaster completed remote builds in B28602: Diff 39695.Apr 30 2024, 7:12 AM
kamil published this revision for review.May 6 2024, 4:26 AM
kamil edited the summary of this revision. (Show Details)
ashoat added inline comments.May 6 2024, 11:43 AM
native/profile/tunnelbroker-menu.react.js
96–117 ↗(On Diff #39695)

This appears to be copy-pasted from D11842. Can we factor it out into a hook?

tomek accepted this revision.May 7 2024, 2:46 AM
This revision is now accepted and ready to land.May 7 2024, 2:46 AM
kamil updated this revision to Diff 39882.May 7 2024, 4:18 AM

factor logic out into a hook

Harbormaster completed remote builds in B28728: Diff 39882.May 7 2024, 4:38 AM
Closed by commit rCOMMd2a13263d231: [native] add test button to create initial peer list (authored by kamil). · Explain WhyMay 7 2024, 4:55 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd2a13263d231: [native] add test button to create initial peer list.

Revision Contents
Changeset List

PathSize
lib/
hooks/
40 lines
native/
profile/
12 lines
web/
settings/
29 lines

Diff 39888

View Options

lib/hooks/peer-list-hooks.js

Loading...
View Options

native/profile/tunnelbroker-menu.react.js

Loading...
View Options

web/settings/account-settings.react.js

Loading...