Details
Details
Tests
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/actions/aux-user-actions.js | ||
---|---|---|
7 ↗ | (On Diff #39693) | Should this be read as "set users' device lists"? I wonder if SET_PEER_DEVICE_LISTS would be more clear |
Comment Actions
- add property inside payload
- SET_USERS_DEVICE_LISTS -> SET_PEER_DEVICE_LISTS
lib/actions/aux-user-actions.js | ||
---|---|---|
7 ↗ | (On Diff #39693) |
yes, that was my intention
agree with that |
lib/reducers/aux-user-reducer.js | ||
92–94 ↗ | (On Diff #39693) |
According to type definition fid is nullable but the field itself should be defined. That being said when adding a peer list to userID that wasn't previously in AuxUserStore we need to do it this way |