Page MenuHomePhabricator

[keyserver] Stop creating two cookies on siwe registration
ClosedPublic

Authored by inka on May 7 2024, 3:53 AM.
Tags
None
Referenced Files
F3384538: D11919.diff
Thu, Nov 28, 9:29 PM
Unknown Object (File)
Mon, Nov 11, 12:47 AM
Unknown Object (File)
Sun, Nov 10, 8:52 PM
Unknown Object (File)
Sun, Nov 10, 4:35 PM
Unknown Object (File)
Sun, Nov 10, 11:41 AM
Unknown Object (File)
Fri, Nov 8, 7:18 PM
Unknown Object (File)
Fri, Nov 8, 5:51 PM
Unknown Object (File)
Fri, Nov 8, 5:25 PM
Subscribers
None

Details

Summary

issue: ENG-8052
We want to match how keyserverAuthResponder was refactored. We want to stop creating two cookies in case of registration. The cookie is created later by processSuccessfulLogin.

Test Plan

Tested that it is possible to register a user with siwe (ENG-8044 still occurs, but the user is added to the table and receives a user cookie).
Tested that it is possible to login with siwe

Diff Detail

Repository
rCOMM Comm
Branch
inka/may2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.May 7 2024, 4:11 AM
ashoat added inline comments.
keyserver/src/responders/user-responders.js
703 ↗(On Diff #39879)

Let's move this check to occur earlier, before the checkAndInvalidateSIWENonceEntry call. I think it's best to call it before we do any mutations

730–741 ↗(On Diff #39879)

Thanks for moving this to happen after processSuccessfulLogin!

This revision is now accepted and ready to land.May 7 2024, 6:56 AM

Move call to verifyCalendarQueryThreadIDs