[keyserver] Create olm session before creating a cookie in createAccount
ClosedPublic
Actions

Authored by inka on May 7 2024, 2:28 AM.

Details

Reviewers

tomek
ashoat

Commits

rCOMM7e3803fc86fc: [keyserver] Create olm session before creating a cookie in createAccount

Summary

issue: ENG-8046
Same as in D11780, we want to firt create the session and only then create the cookie (and in this case also add the new user to the db), so that in case the olm session creation fails, the user does not get logged in anyway

Test Plan

Tested that before this diff, if creating the olm session failed (olmSessionPromise threw), then the user would still get registered and get a user cookie.
Checked that after this diff, if olmNotifSession throws, the user is not created in the db and they don't get a userm cookie

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.May 7 2024, 2:28 AM

inka added a parent revision: D11780: [keyserver] Fix sending a user cookie when olm session creation failed.May 7 2024, 2:29 AM

Harbormaster completed remote builds in B28723: Diff 39877.May 7 2024, 2:45 AM

inka requested review of this revision.May 7 2024, 2:45 AM

inka added a child revision: D11918: [keyserver] Move accepting policies on siwe registration.May 7 2024, 3:15 AM

ashoat accepted this revision.May 7 2024, 6:46 AM

ashoat added inline comments.

keyserver/src/creators/account-creator.js
103 ↗	(On Diff #39877)	I've noticed this pattern in several places, where people seem to all-caps "Olm". I don't understand why... the makers spell it as "Olm", and it is not an acronym or initialism. Can you stick with "Olm" please? (If this was copied from somewhere, please update that place as well.)