[keyserver] Stop creating two cookies on siwe registration
ClosedPublic
Actions

Authored by inka on May 7 2024, 3:53 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMa6cf94df52df: [keyserver] Stop creating two cookies on siwe registration

Summary

issue: ENG-8052
We want to match how keyserverAuthResponder was refactored. We want to stop creating two cookies in case of registration. The cookie is created later by processSuccessfulLogin.

Test Plan

Tested that it is possible to register a user with siwe (ENG-8044 still occurs, but the user is added to the table and receives a user cookie).
Tested that it is possible to login with siwe

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.May 7 2024, 3:53 AM

inka added a parent revision: D11918: [keyserver] Move accepting policies on siwe registration.May 7 2024, 3:53 AM

Harbormaster completed remote builds in B28725: Diff 39879.May 7 2024, 4:11 AM

inka requested review of this revision.May 7 2024, 4:11 AM

ashoat accepted this revision.May 7 2024, 6:56 AM

ashoat added inline comments.

keyserver/src/responders/user-responders.js
703 ↗	(On Diff #39879)	Let's move this check to occur earlier, before the `checkAndInvalidateSIWENonceEntry` call. I think it's best to call it before we do any mutations
730–741 ↗	(On Diff #39879)	Thanks for moving this to happen after `processSuccessfulLogin`!