Page MenuHomePhabricator
Differential D11974

[native] Make Farcaster required in new registration flow
ClosedPublic
Actions

Authored by ashoat on May 9 2024, 7:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 3:42 AM
Unknown Object (File)
Nov 3 2024, 3:15 AM
Unknown Object (File)
Oct 12 2024, 11:13 AM
Unknown Object (File)
Oct 12 2024, 11:13 AM
Unknown Object (File)
Oct 12 2024, 11:13 AM
Unknown Object (File)
Oct 12 2024, 11:13 AM
Unknown Object (File)
Oct 12 2024, 11:13 AM
Unknown Object (File)
Oct 12 2024, 11:13 AM
View All 93 Files
Subscribers
tomek

Details

Reviewers
ginsu
inka
Commits
rCOMM8d8cc1e42c44: [native] Make Farcaster required in new registration flow
Summary

Only making it required on release builds to avoid making testing more difficult for devs.

Depends on D11973

Test Plan

Replaced usage of __DEV__ with a hardcoded variable. Tested opening the registration flow from the main screen and from FullscreenSIWEPanel. Make sure CoolOrNerdModeSelection and KeyserverSelection don't appear. Make sure that I am able to successfully register

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.May 9 2024, 7:56 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 9 2024, 7:56 AM
Harbormaster completed remote builds in B28812: Diff 40022.May 9 2024, 8:13 AM
ashoat requested review of this revision.May 9 2024, 8:13 AM
tomek added inline comments.May 9 2024, 8:18 AM
native/account/registration/connect-farcaster.react.js
186 ↗(On Diff #40022)

How about staff users? I know this is about registration, but are we going to require a Farcaster account for possible new developers?

ashoat added inline comments.May 9 2024, 12:22 PM
native/account/registration/connect-farcaster.react.js
186 ↗(On Diff #40022)

Good point, I can add an exception for staff builds

ashoat updated this revision to Diff 40036.May 9 2024, 12:57 PM

useStaffCanSee to allow staff to circumvent Farcaster requirement

ashoat updated this revision to Diff 40037.May 9 2024, 12:58 PM

Minor

ashoat updated this revision to Diff 40038.May 9 2024, 12:59 PM

Typo

ashoat updated this revision to Diff 40039.May 9 2024, 1:03 PM

Spacing

ginsu accepted this revision.May 9 2024, 1:06 PM
ginsu added inline comments.
native/components/farcaster-prompt.react.js
30

Nit/unsolicited, but I think we can drop "currently". Will defer to you to make the final call

This revision is now accepted and ready to land.May 9 2024, 1:06 PM
ashoat added inline comments.May 9 2024, 1:10 PM
native/components/farcaster-prompt.react.js
30

I'd rather keep it

This revision was landed with ongoing or failed builds.May 9 2024, 1:11 PM
Closed by commit rCOMM8d8cc1e42c44: [native] Make Farcaster required in new registration flow (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM8d8cc1e42c44: [native] Make Farcaster required in new registration flow.
Harbormaster completed remote builds in B28820: Diff 40036.May 9 2024, 1:14 PM
Harbormaster completed remote builds in B28822: Diff 40038.May 9 2024, 1:16 PM
Harbormaster completed remote builds in B28821: Diff 40037.
Harbormaster completed remote builds in B28823: Diff 40039.May 9 2024, 1:19 PM

Revision Contents
Changeset List

PathSize
native/
account/
registration/
27 lines
components/
2 lines
37 lines
profile/
5 lines

Diff 40039

View Options

native/account/registration/connect-farcaster.react.js

Loading...
View Options

native/components/connect-farcaster-bottom-sheet.react.js

Loading...
View Options

native/components/farcaster-prompt.react.js

Loading...
View Options

native/profile/farcaster-account-settings.react.js

Loading...