Paths

Table of Contentst

Differential D11974

[native] Make Farcaster required in new registration flow
ClosedPublic
Actions

Authored by ashoat on May 9 2024, 7:56 AM.

Tags

None

Referenced Files

	F2193639: D11974.id40022.diff
	Thu, Jul 4, 10:41 PM

	F2193342: D11974.id40036.diff
	Thu, Jul 4, 9:48 PM

	F2193320: D11974.id40043.diff
	Thu, Jul 4, 9:43 PM

	F2193292: D11974.id40038.diff
	Thu, Jul 4, 9:37 PM

	F2193210: D11974.id40039.diff
	Thu, Jul 4, 9:25 PM

	F2193208: D11974.id40037.diff
	Thu, Jul 4, 9:24 PM

	F2192817: D11974.id40022.diff
	Thu, Jul 4, 8:32 PM

	Unknown Object (File)
	Tue, Jul 2, 9:30 PM

View All 54 Files

Subscribers

Details

Reviewers

ginsu
inka

Commits

rCOMM8d8cc1e42c44: [native] Make Farcaster required in new registration flow

Summary

Only making it required on release builds to avoid making testing more difficult for devs.

Depends on D11973

Test Plan

Replaced usage of __DEV__ with a hardcoded variable. Tested opening the registration flow from the main screen and from FullscreenSIWEPanel. Make sure CoolOrNerdModeSelection and KeyserverSelection don't appear. Make sure that I am able to successfully register

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 9 2024, 7:56 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 9 2024, 7:56 AM

Harbormaster completed remote builds in B28812: Diff 40022.May 9 2024, 8:13 AM

ashoat requested review of this revision.May 9 2024, 8:13 AM

tomek added inline comments.May 9 2024, 8:18 AM

native/account/registration/connect-farcaster.react.js
186 ↗	(On Diff #40022)	How about staff users? I know this is about registration, but are we going to require a Farcaster account for possible new developers?

ashoat added inline comments.May 9 2024, 12:22 PM

native/account/registration/connect-farcaster.react.js
186 ↗	(On Diff #40022)	Good point, I can add an exception for staff builds

useStaffCanSee to allow staff to circumvent Farcaster requirement

Minor

Typo

Spacing

ginsu accepted this revision.May 9 2024, 1:06 PM

ginsu added inline comments.

native/components/farcaster-prompt.react.js
30 ↗	(On Diff #40039)	Nit/unsolicited, but I think we can drop "currently". Will defer to you to make the final call

This revision is now accepted and ready to land.May 9 2024, 1:06 PM

ashoat added inline comments.May 9 2024, 1:10 PM

native/components/farcaster-prompt.react.js
30 ↗	(On Diff #40039)	I'd rather keep it

This revision was landed with ongoing or failed builds.May 9 2024, 1:11 PM

Closed by commit rCOMM8d8cc1e42c44: [native] Make Farcaster required in new registration flow (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8d8cc1e42c44: [native] Make Farcaster required in new registration flow.

Harbormaster completed remote builds in B28820: Diff 40036.May 9 2024, 1:14 PM

Harbormaster completed remote builds in B28822: Diff 40038.May 9 2024, 1:16 PM

Harbormaster completed remote builds in B28821: Diff 40037.

Harbormaster completed remote builds in B28823: Diff 40039.May 9 2024, 1:19 PM

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

connect-farcaster.react.js

27 lines

components/

connect-farcaster-bottom-sheet.react.js

2 lines

farcaster-prompt.react.js

37 lines

profile/

farcaster-account-settings.react.js

5 lines

Diff 40043

native/account/registration/connect-farcaster.react.js

Loading...

native/components/connect-farcaster-bottom-sheet.react.js

Loading...

native/components/farcaster-prompt.react.js

Loading...

native/profile/farcaster-account-settings.react.js

Loading...