Page MenuHomePhabricator

[native] Don't skip ConnectEthereum if nonce is expired
ClosedPublic

Authored by ashoat on May 12 2024, 7:32 PM.
Tags
None
Referenced Files
F3275969: D12007.diff
Sat, Nov 16, 7:16 AM
Unknown Object (File)
Thu, Nov 7, 4:26 AM
Unknown Object (File)
Sun, Nov 3, 5:38 AM
Unknown Object (File)
Oct 12 2024, 2:56 PM
Unknown Object (File)
Oct 12 2024, 2:56 PM
Unknown Object (File)
Oct 12 2024, 2:55 PM
Unknown Object (File)
Oct 12 2024, 2:55 PM
Unknown Object (File)
Sep 21 2024, 9:15 PM
Subscribers

Details

Summary

If the nonce used for SIWE will be rejected by the relevant backend (authoritative keyserver or identity service, depending on usingCommServicesAccessToken) due to expiration, then we should force the user to generate a new SIWE signature.

Would normally put @varun on the review here, but going to ask @inka instead because he is out.

Depends on D12006

Test Plan

I tested (or will test) this diff stack as follows:

  1. Be in a multi-keyserver environment, testing SIWE with iOS simulator
  2. Do a SIWE and then wait 2 minutes to let the nonce expire in the following screens:
    • FullscreenSIWEPanel for an account that doesn't exist yet when the new registration flow is disabled
    • FullscreenSIWEPanel for an account that doesn't exist yet when the new registration flow is enabled
    • FullscreenSIWEPanel for an account that does exist
    • New registration flow for an account that doesn't exist yet (RegistrationTerms)
    • New registration flow for an account that does exist (ExistingEthereumAccount)
  3. Make sure there are no duplicate Alerts, that in all cases an Alert is shown, and that the "back" action activates when the user confirms the Alert

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage