Page MenuHomePhabricator
Differential D12002

[terraform] display comm-lib debug logs on identity
ClosedPublic
Actions

Authored by will on May 11 2024, 10:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 4:26 AM
Unknown Object (File)
Sun, Nov 3, 4:26 AM
Unknown Object (File)
Sun, Nov 3, 4:26 AM
Unknown Object (File)
Sun, Nov 3, 4:25 AM
Unknown Object (File)
Sun, Nov 3, 4:24 AM
Unknown Object (File)
Oct 1 2024, 4:49 PM
Unknown Object (File)
Sep 26 2024, 2:27 AM
Unknown Object (File)
Sep 26 2024, 2:27 AM
View All 60 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
kamil
Commits
rCOMM2f146282117d: [terraform] display comm-lib debug logs on identity
Summary

We should include comm-lib as part of our debug logs for identity on staging

Test Plan

terraform apply

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.May 11 2024, 10:49 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 11 2024, 10:49 AM
will added a child revision: D12003: [terraform] set all rust services to debug on staging.May 11 2024, 10:50 AM
will edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B28854: Diff 40095.May 11 2024, 11:04 AM
will requested review of this revision.May 11 2024, 11:04 AM
will retitled this revision from [terraform] display comm-lib debug logs to [terraform] display comm-lib debug logs on identity.May 11 2024, 11:08 AM
bartek accepted this revision.May 13 2024, 12:18 AM
This revision is now accepted and ready to land.May 13 2024, 12:18 AM
bartek requested changes to this revision.May 13 2024, 12:21 AM

Actually it should be comm_lib, not comm-lib. Verified that locally

services/terraform/remote/service_identity.tf
69 ↗(On Diff #40095)
This revision now requires changes to proceed.May 13 2024, 12:21 AM
bartek mentioned this in D12003: [terraform] set all rust services to debug on staging.May 13 2024, 12:26 AM
will updated this revision to Diff 40196.May 14 2024, 9:16 PM

Fix comm-lib as comm_lib in env variable

Harbormaster completed remote builds in B28922: Diff 40196.May 14 2024, 9:32 PM
bartek accepted this revision.May 14 2024, 11:52 PM
This revision is now accepted and ready to land.May 14 2024, 11:52 PM
Closed by commit rCOMM2f146282117d: [terraform] display comm-lib debug logs on identity (authored by will). · Explain WhyMay 15 2024, 8:01 AM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM2f146282117d: [terraform] display comm-lib debug logs on identity.

Revision Contents
Changeset List

PathSize
services/
terraform/
remote/
2 lines

Diff 40196

View Options

services/terraform/remote/service_identity.tf

Loading...