Differential D12054

[web] Disable AddKeyserverModal button while keyserver check is in progress
ClosedPublic
Actions

Authored by ashoat on May 15 2024, 9:44 AM.

Details

Reviewers

Commits

rCOMMa8c9af07540d: [web] Disable AddKeyserverModal button while keyserver check is in progress

Summary

We should never ever introduce an interface without considering loading state. This was a huge omission in the initial work on this project.

Depends on D12053

Test Plan

Added a sleep for this video:

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 15 2024, 9:44 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 15 2024, 9:44 AM

ashoat added a child revision: D12055: [native] Disable AddKeyserver button while keyserver check is in progress.May 15 2024, 9:46 AM

ashoat edited the test plan for this revision. (Show Details)May 15 2024, 9:52 AM

Harbormaster completed remote builds in B28950: Diff 40234.May 15 2024, 10:01 AM

ashoat requested review of this revision.May 15 2024, 10:01 AM

ginsu accepted this revision.May 15 2024, 11:05 AM

This revision is now accepted and ready to land.May 15 2024, 11:05 AM

Closed by commit rCOMMa8c9af07540d: [web] Disable AddKeyserverModal button while keyserver check is in progress (authored by ashoat). · Explain WhyMay 15 2024, 12:11 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa8c9af07540d: [web] Disable AddKeyserverModal button while keyserver check is in progress.

Revision Contents
Changeset List

Path

Size

web/

modals/

keyserver-selection/

add-keyserver-modal.react.js

24 lines

Diff 40234

View Options

web/modals/keyserver-selection/add-keyserver-modal.react.js

[web] Disable AddKeyserverModal button while keyserver check is in progressClosedPublicActions