[lib] dispatch actions and populate aux user store with fids
ClosedPublic
Actions

Authored by will on May 12 2024, 8:10 PM.

Details

Reviewers

ginsu
ashoat

Commits

rCOMM8f250e7a9859: [lib] dispatch actions and populate aux user store with fids

Summary

Depends on D12105

Test Plan

Hardcoded userIDs from staging as the user store and confirmed aux user store was populated with fids on connecting farcaster account

Diffed up first without a full end to end test. Will not land until I verify that the aux user store is properly populated with fids for users in the User Store

Diff Detail

Repository

rCOMM Comm

Branch

farcaster/set_aux_user_fids

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.May 12 2024, 8:10 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 12 2024, 8:10 PM

will added 1 blocking reviewer(s): ginsu.May 12 2024, 8:11 PM

Harbormaster completed remote builds in B28863: Diff 40104.May 12 2024, 8:27 PM

will requested review of this revision.May 12 2024, 8:27 PM

ashoat requested changes to this revision.May 13 2024, 3:31 PM

ashoat added inline comments.

lib/components/farcaster-data-handler.react.js
110–133 ↗	(On Diff #40104)	It doesn't seem like this logic is connected at all to the block you put it in. This makes the code more confusing, and it forces your logic to wait on the other logic to complete before being able to proceed. I think we should factor it out. What if we had a single effect that called two `React.useCallback`s, each of which was responsible for one of these blocks of functionality? We should also probably move some of the checks on lines from 70 to 80 to the callbacks
116–122 ↗	(On Diff #40104)	Shorthand
124–133 ↗	(On Diff #40104)	Doing two dispatches in a row like this is an anti-pattern... do you think we could introduce a `replaceAuxUserFIDsActionType`?

This revision now requires changes to proceed.May 13 2024, 3:31 PM

will added inline comments.May 13 2024, 3:59 PM

lib/components/farcaster-data-handler.react.js
124–133 ↗	(On Diff #40104)	I agree with these suggestions. Will include a new action type in a separate diff and separate logic into two `React.useCallbacks` on next rebase

will mentioned this in D12105: [lib] modify set aux user fids and replace old behavior with add aux user fids action type.May 20 2024, 1:29 AM

review feedback

will removed 1 blocking reviewer(s): ginsu.May 20 2024, 1:39 AM

will edited the summary of this revision. (Show Details)

will added a parent revision: D12105: [lib] modify set aux user fids and replace old behavior with add aux user fids action type.

will marked an inline comment as done.

will added inline comments.May 20 2024, 1:43 AM

lib/components/farcaster-data-handler.react.js
129–134	I introduced a previous diff where `setAuxUserFIDs` now clears fids prior to updating with new fids from the payload. The previous functionality of `setAuxUserFIDs` of just adding without clearing is now a new action type `addAuxUserFIDs` There are now two callbacks which are called by a single useEffect. The two callbacks are called handleFarcasterMutuals and handleUserStoreFIDs