Page MenuHomePhabricator

Refactor get user identifier to return identity with farcaster id
ClosedPublic

Authored by will on Wed, May 8, 10:32 PM.
Tags
None
Referenced Files
F1782650: D11951.id39959.diff
Sat, May 18, 8:20 AM
Unknown Object (File)
Fri, May 17, 8:10 AM
Unknown Object (File)
Tue, May 14, 8:39 PM
Unknown Object (File)
Mon, May 13, 4:28 PM
Unknown Object (File)
Sat, May 11, 8:40 PM
Unknown Object (File)
Fri, May 10, 4:22 AM
Unknown Object (File)
Fri, May 10, 4:22 AM
Unknown Object (File)
Fri, May 10, 4:21 AM
Subscribers

Details

Summary

This includes a new identity struct with a farcaster id field which we refactor get_user_identifier to return. This follows discussion from
https://linear.app/comm/issue/ENG-7759/modify-finduseridentity-to-take-list-of-userids-and-include-fid.

Depends on D11859

Test Plan

cargo check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will retitled this revision from Refactor Identifier to include farcaster id to Refactor get user identifier to return identity with farcaster id.Wed, May 8, 10:33 PM
will edited the summary of this revision. (Show Details)
services/identity/src/database.rs
25 ↗(On Diff #39959)

Decided to name this DBIdentity to avoid confusion with proto Identity message. Let me know if there's an alternative name I could use

will requested review of this revision.Wed, May 8, 10:49 PM

Technically it looks okay. I like the renames you did. Just please apply the inline comment

services/identity/src/ddb_utils.rs
193–195 ↗(On Diff #39959)

I think it should be merged. This way, it gets None when the attribute doesn't exist, but still fail when parsing fails (e.g. it's not a String)

This revision is now accepted and ready to land.Wed, May 8, 11:12 PM