Refactor get user identifier to return identity with farcaster id
ClosedPublic
Actions

Authored by will on May 8 2024, 10:32 PM.

Details

Reviewers

bartek
kamil

Commits

rCOMM9a2f04e09c7f: Refactor get user identifier to return identity with farcaster id

Summary

This includes a new identity struct with a farcaster id field which we refactor get_user_identifier to return. This follows discussion from
https://linear.app/comm/issue/ENG-7759/modify-finduseridentity-to-take-list-of-userids-and-include-fid.

Depends on D11859

Test Plan

cargo check

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.May 8 2024, 10:32 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 8 2024, 10:32 PM

will retitled this revision from Refactor Identifier to include farcaster id to Refactor get user identifier to return identity with farcaster id.May 8 2024, 10:33 PM

will edited the summary of this revision. (Show Details)

will added a parent revision: D11859: [lib] Rename action type to set aux user fids.

will added inline comments.May 8 2024, 10:42 PM

services/identity/src/database.rs
25	Decided to name this DBIdentity to avoid confusion with proto Identity message. Let me know if there's an alternative name I could use

will added a child revision: D11952: [identity] modify get user identity rpc to take user ids and return identity map with farcaster id.May 8 2024, 10:43 PM

Harbormaster completed remote builds in B28772: Diff 39959.May 8 2024, 10:49 PM

will requested review of this revision.May 8 2024, 10:49 PM

Technically it looks okay. I like the renames you did. Just please apply the inline comment

services/identity/src/ddb_utils.rs
193–195	I think it should be merged. This way, it gets `None` when the attribute doesn't exist, but still fail when parsing fails (e.g. it's not a `String`)