Page MenuHomePhabricator
Differential D12281

[blob] Don't check if the invite link is reserved
ClosedPublic
Actions

Authored by tomek on Jun 3 2024, 5:39 AM.
Tags
None
Referenced Files
F3353253: D12281.id40847.diff
Sat, Nov 23, 9:02 AM
F3353225: D12281.id40856.diff
Sat, Nov 23, 8:55 AM
F3352511: D12281.diff
Sat, Nov 23, 6:15 AM
Unknown Object (File)
Tue, Nov 12, 3:32 PM
Unknown Object (File)
Tue, Nov 12, 2:48 PM
Unknown Object (File)
Tue, Nov 12, 2:29 PM
Unknown Object (File)
Tue, Nov 12, 11:10 AM
Unknown Object (File)
Fri, Nov 8, 2:28 AM
View All 92 Files
Subscribers
ashoat

Details

Reviewers
bartek
varun
Commits
rCOMMfda12f9dcff2: [blob] Don't check if the invite link is reserved
Summary

We're checking this only on the keyserver side for now.

https://linear.app/comm/issue/ENG-8302/stop-checking-if-an-invite-link-contains-a-reserved-username-on-blob

Test Plan

Run a local blob service, comment out reserved link check on a keyserver. Create a reserved link, open it and verify that the blob was downloaded using the browser inspector. Also check if offensive links check still works on keyserver.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
blob/
src/
4 lines

Diff 40856

View Options

services/blob/src/service.rs

Loading...