Page MenuHomePhabricator
Differential D12385

[native] add autoCapitalize="none"
ClosedPublic
Actions

Authored by varun on Jun 10 2024, 1:09 PM.
Tags
None
Referenced Files
F3497369: D12385.diff
Thu, Dec 19, 6:56 PM
Unknown Object (File)
Wed, Dec 18, 10:32 PM
Unknown Object (File)
Wed, Dec 18, 9:59 PM
Unknown Object (File)
Wed, Dec 18, 9:44 PM
Unknown Object (File)
Sun, Dec 15, 3:05 AM
Unknown Object (File)
Sun, Dec 15, 3:05 AM
Unknown Object (File)
Sun, Dec 15, 3:05 AM
Unknown Object (File)
Sun, Dec 15, 3:05 AM
View All 91 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMMa936d5f5ebac: [native] add autoCapitalize="none"
Summary

we want this on all password inputs

Test Plan

checked code and confirmed that other password TextInputs have this property. checked docs and it should be safe in this context

no regression when running android emulator

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Jun 10 2024, 1:09 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 10 2024, 1:09 PM
Harbormaster completed remote builds in B29584: Diff 41175.Jun 10 2024, 1:33 PM
varun requested review of this revision.Jun 10 2024, 1:33 PM
ashoat accepted this revision.Jun 10 2024, 1:43 PM

I'd frame the test plan as something like "checked code and confirmed that other password TextInputs have this property. checked docs and it should be safe in this context"

Test plan should be thought of as "how I know this change is safe"

This revision is now accepted and ready to land.Jun 10 2024, 1:43 PM
varun edited the test plan for this revision. (Show Details)Jun 10 2024, 1:44 PM
varun updated this revision to Diff 41180.Jun 10 2024, 1:58 PM
varun edited the test plan for this revision. (Show Details)
varun added 1 blocking reviewer(s): ashoat.

update test plan

This revision now requires review to proceed.Jun 10 2024, 1:58 PM
varun removed 1 blocking reviewer(s): ashoat.Jun 10 2024, 1:58 PM
varun updated this revision to Diff 41181.Jun 10 2024, 1:59 PM

messed up test plan update

varun edited the test plan for this revision. (Show Details)Jun 10 2024, 2:00 PM
ashoat accepted this revision.Jun 10 2024, 2:01 PM
This revision is now accepted and ready to land.Jun 10 2024, 2:01 PM
This revision was landed with ongoing or failed builds.Jun 10 2024, 2:05 PM
Closed by commit rCOMMa936d5f5ebac: [native] add autoCapitalize="none" (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMa936d5f5ebac: [native] add autoCapitalize="none".
Harbormaster completed remote builds in B29588: Diff 41180.Jun 10 2024, 2:14 PM
Harbormaster completed remote builds in B29589: Diff 41181.Jun 10 2024, 2:19 PM

Revision Contents
Changeset List

PathSize
native/
profile/
1 line

Diff 41193

View Options

native/profile/delete-account.react.js

Loading...