[identity][websocket] Call DB client directly to verify CSAT
ClosedPublic
Actions

Authored by bartek on Jun 17 2024, 3:30 AM.

Details

Reviewers

will
varun

Commits

rCOMMe62070d59fdf: [identity][websocket] Call DB client directly to verify CSAT

Summary

Noticed that we're doing an unnecessary round-trip with search WebSocket auth:
Identity WS, when received auth message, connected to itself via gRPC just to verify CSAT.

Replaced this with a direct DDB call.

Test Plan

Verified that identity search is still working on local clients (with local Identity).

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 17 2024, 3:30 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 17 2024, 3:30 AM

Harbormaster completed remote builds in B29709: Diff 41378.Jun 17 2024, 3:46 AM

bartek published this revision for review.Jun 17 2024, 4:22 AM

This makes a lot of sense. Not sure why I didn't consider this on first implementation but glad you caught it now.

This revision is now accepted and ready to land.Jun 18 2024, 7:15 AM

Closed by commit rCOMMe62070d59fdf: [identity][websocket] Call DB client directly to verify CSAT (authored by bartek). · Explain WhyJun 19 2024, 2:23 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMe62070d59fdf: [identity][websocket] Call DB client directly to verify CSAT.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

websockets/

auth.rs

95 lines

mod.rs

12 lines

Diff 41378

View Options

services/identity/src/websockets/auth.rs