Page MenuHomePhabricator
Differential D12535

[lib/native] introduce useCreateFarcasterChannelTag
ClosedPublic
Actions

Authored by ginsu on Jun 20 2024, 8:46 PM.
Tags
None
Referenced Files
F3276178: D12535.diff
Sat, Nov 16, 7:23 AM
F3248848: D12535.id41618.diff
Fri, Nov 15, 11:04 AM
Unknown Object (File)
Fri, Nov 15, 4:10 AM
Unknown Object (File)
Fri, Nov 15, 3:35 AM
Unknown Object (File)
Fri, Nov 15, 3:02 AM
Unknown Object (File)
Sun, Nov 10, 1:05 AM
Unknown Object (File)
Fri, Nov 1, 12:49 PM
Unknown Object (File)
Fri, Nov 1, 12:49 PM
View All 50 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
kamil
Commits
rCOMMed338cd1770c: [lib/native] introduce useCreateFarcasterChannelTag
Summary

We are going to want both this logic on both web and native. Created this shared hook that factors out all the shared logic for creating a farcaster channel tag

Test Plan

flow + confirmed no regressions with creating a farcaster channel tag on native

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 20 2024, 8:46 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 8:46 PM
ginsu edited the summary of this revision. (Show Details)Jun 20 2024, 8:47 PM
ginsu added reviewers: inka, kamil.
ginsu added a parent revision: D12534: [lib/native/web] introduce RemoveTagButton.
Harbormaster completed remote builds in B29859: Diff 41594.Jun 20 2024, 9:02 PM
ginsu requested review of this revision.Jun 20 2024, 9:02 PM
inka accepted this revision.Jun 21 2024, 1:17 AM
This revision is now accepted and ready to land.Jun 21 2024, 1:17 AM
ginsu edited the summary of this revision. (Show Details)Jun 21 2024, 11:21 AM
ginsu removed a parent revision: D12534: [lib/native/web] introduce RemoveTagButton.

Removed from stack so I can land as is. Confirmed that this is safe + does not cause any merge conflicts when rebasing

ginsu updated this revision to Diff 41618.Jun 21 2024, 11:22 AM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 21 2024, 11:23 AM
Closed by commit rCOMMed338cd1770c: [lib/native] introduce useCreateFarcasterChannelTag (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMed338cd1770c: [lib/native] introduce useCreateFarcasterChannelTag.
Harbormaster completed remote builds in B29876: Diff 41618.Jun 21 2024, 11:37 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
58 lines
native/
community-settings/
tag-farcaster-channel/
65 lines

Diff 41618

View Options

lib/shared/community-utils.js

Loading...
View Options

native/community-settings/tag-farcaster-channel/tag-channel-button.react.js

Loading...